[GitHub] [lucene-solr] yonik commented on a change in pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient

[GitBox <gi...@apache.org>]

yonik commented on a change in pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient
URL: https://github.com/apache/lucene-solr/pull/850#discussion_r321048686
 
 

 ##########
 File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
 ##########
 @@ -330,6 +333,12 @@ protected ModifiableSolrParams calculateQueryParams(Set<String> queryParamNames,
     }
     return queryModParams;
   }
+  
+  private String changeV2RequestEndpoint(String basePath) throws MalformedURLException {
 
 Review comment:
   This is a widely used client class, so we should probably be slightly more wary of adding public methods.  Perhaps package protected static... until we need it to be public for some reason.  I'll make that change when I commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org