You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by smarthi <gi...@git.apache.org> on 2015/01/28 05:54:26 UTC
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-samoa/pull/4
SAMOA-10: Incorrect String comparison in Clustering.java
Fixes SAMOA-10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-samoa suneel1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 49fab46adbe0c0ed8ad1df607087e708893ed0f4
Author: Suneel Marthi <su...@gmail.com>
Date: 2015-01-28T04:53:07Z
SAMOA-10: Incorrect String comparison in Clustering.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-11: Incorrect String compariso...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi closed the pull request at:
https://github.com/apache/incubator-samoa/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by gdfm <gi...@git.apache.org>.
Github user gdfm commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77564374
There seems to be a lot of formatting changes, but I cannot identify the gist of the patch.
What was the bug? Can you add a test to reproduce it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77601173
This PR predates the formatting changes that were committed later, hence u see all the formatting. I am thinking I'll close this PR and create another that has the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77602796
ok I'll update this PR, I squash my commits anyways before pushing a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by abifet <gi...@git.apache.org>.
Github user abifet commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77092519
+1 to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77094833
Fixes SAMOA-11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-10: Incorrect String compariso...
Posted by gdfm <gi...@git.apache.org>.
Github user gdfm commented on the pull request:
https://github.com/apache/incubator-samoa/pull/4#issuecomment-77602152
No need to open a new PR. Simply push the new code on the same branch.
We will take care of squashing it on our side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---