You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by YCjia <gi...@git.apache.org> on 2018/07/20 09:24:51 UTC
[GitHub] flink pull request #6378: [FLINK-9236] [pom] upgrade the version of apache p...
GitHub user YCjia opened a pull request:
https://github.com/apache/flink/pull/6378
[FLINK-9236] [pom] upgrade the version of apache parent pom
## What is the purpose of the change
This PR is for upgrading the version of Apache Parent Pom used by flink.
## Brief change log
* The version of Apache parent pom changed form 18 to 19 in pom.xml
* Specify the version of plugin/maven-assembly-plugin to 2.6 in flink-libraries/flink-python/pom.xml .
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YCjia/flink flink-9236
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6378
----
commit 1d959ed260d770a59f8f9809e7057ce115940d36
Author: jyc.jia <jy...@...>
Date: 2018-07-20T07:45:01Z
[FLINK-9236] [pom] upgrade the version of apache parent pom from 18 to 19
----
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by YCjia <gi...@git.apache.org>.
Github user YCjia commented on the issue:
https://github.com/apache/flink/pull/6378
@TisonShadowsong @zhangminglei I ran these tests locally, but they all succeeded, and the Travis CI build for my fork repository passed too. https://travis-ci.com/YCjia/flink/builds
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6378
Could you please push code and trigger the travis again ?
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6378
No particular reason - considering the date when JIRA was first logged :-)
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6378
lgtm
Pending QA bot
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6378
@TisonShadowsong is right. You can verify that and i think it might be a bug.
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by TisonShadowsong <gi...@git.apache.org>.
Github user TisonShadowsong commented on the issue:
https://github.com/apache/flink/pull/6378
The test that fails is `WindowCheckpointingITCase`, not sure but @YCjia you can run it locally to figure out what happened.
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/6378
Any reason not to use version 20 or are we just being conservative?
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6378
@zhangminglei @YCjia Please do not push changes for the sole purpose of re-triggering Travis. We already know that they passed (due to the travis fork), and realistically there's no way for the parent pom to influence this test.
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by YCjia <gi...@git.apache.org>.
Github user YCjia commented on the issue:
https://github.com/apache/flink/pull/6378
@greghogan Thanks for your reminder. Since version 20 was released on July 7, 2018, I think it is more appropriate to use version 20. I have modified the code I submitted. I am a newbie here, please point out my mistake.
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6378
@YCjia The travis test failed. Could you take a look on what is happening ?
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by YCjia <gi...@git.apache.org>.
Github user YCjia commented on the issue:
https://github.com/apache/flink/pull/6378
@zentol Thank you for your reminder, I will pay attention in the future.
---
[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6378
merging.
---