You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2019/12/12 19:04:11 UTC

[isis] branch master updated: ISIS-2177: remove SessionScopedComponent for good

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new c4cff76  ISIS-2177: remove SessionScopedComponent for good
c4cff76 is described below

commit c4cff76fc8b642bd444b1410b1cf480755260666
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Dec 12 20:03:59 2019 +0100

    ISIS-2177: remove SessionScopedComponent for good
    
    also remove debug code
---
 .../components/SessionScopedComponent.java         | 36 ----------------------
 .../fixtures/fixturescripts/FixtureScripts.java    |  7 +----
 2 files changed, 1 insertion(+), 42 deletions(-)

diff --git a/core/commons/src/main/java/org/apache/isis/commons/internal/components/SessionScopedComponent.java b/core/commons/src/main/java/org/apache/isis/commons/internal/components/SessionScopedComponent.java
deleted file mode 100644
index b457614..0000000
--- a/core/commons/src/main/java/org/apache/isis/commons/internal/components/SessionScopedComponent.java
+++ /dev/null
@@ -1,36 +0,0 @@
-/*
- *  Licensed to the Apache Software Foundation (ASF) under one
- *  or more contributor license agreements.  See the NOTICE file
- *  distributed with this work for additional information
- *  regarding copyright ownership.  The ASF licenses this file
- *  to you under the Apache License, Version 2.0 (the
- *  "License"); you may not use this file except in compliance
- *  with the License.  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing,
- *  software distributed under the License is distributed on an
- *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- *  KIND, either express or implied.  See the License for the
- *  specific language governing permissions and limitations
- *  under the License.
- */
-
-package org.apache.isis.commons.internal.components;
-
-/**
- * Indicate that the implementing component is scoped at the session level (for
- * a single user) and might also need to be "opened" or "closed" at the
- * start/end of the session.
- *
- * <p>
- * Analogous to Hibernate's <tt>Session</tt>.
- *
- * @see ApplicationScopedComponent
- * @see TransactionScopedComponent
- */
-public interface SessionScopedComponent extends Component {
-
-
-}
diff --git a/extensions/testing/fixtures/src/main/java/org/apache/isis/extensions/fixtures/fixturescripts/FixtureScripts.java b/extensions/testing/fixtures/src/main/java/org/apache/isis/extensions/fixtures/fixturescripts/FixtureScripts.java
index ae9e71b..219562a 100644
--- a/extensions/testing/fixtures/src/main/java/org/apache/isis/extensions/fixtures/fixturescripts/FixtureScripts.java
+++ b/extensions/testing/fixtures/src/main/java/org/apache/isis/extensions/fixtures/fixturescripts/FixtureScripts.java
@@ -188,7 +188,6 @@ public class FixtureScripts extends AbstractService {
     private final SortedMap<String,FixtureScript> fixtureScriptByFriendlyName;
 
     public FixtureScripts(
-            @SuppressWarnings("OptionalUsedAsFieldOrParameterType")
             final Optional<FixtureScriptsSpecificationProvider> fixtureScriptsSpecificationProvider,
             final ServiceRegistry serviceRegistry) {
 
@@ -341,11 +340,7 @@ public class FixtureScripts extends AbstractService {
     	String parameters = null;
     	
     	transactionService.executeWithinTransaction(()->{
-    	    try {
-    	        runScript(singleScript, parameters);
-    	    } catch (Exception e) {
-    	        throw _Exceptions.unrecoverable(e);
-            }
+    	    runScript(singleScript, parameters);
     	});
     }