You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2012/08/07 14:36:08 UTC
svn commit: r1370207 -
/lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java
Author: mikemccand
Date: Tue Aug 7 12:36:08 2012
New Revision: 1370207
URL: http://svn.apache.org/viewvc?rev=1370207&view=rev
Log:
LUCENE-3892: add nocommit
Modified:
lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java
Modified: lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java?rev=1370207&r1=1370206&r2=1370207&view=diff
==============================================================================
--- lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java (original)
+++ lucene/dev/branches/pforcodec_3892/lucene/core/src/java/org/apache/lucene/codecs/block/BlockPostingsReader.java Tue Aug 7 12:36:08 2012
@@ -530,9 +530,13 @@ public final class BlockPostingsReader e
if (docUpto == docFreq) {
return doc = NO_MORE_DOCS;
}
+
+ // nocommit: in theory we should not hit this? ie
+ // skipper should already have moved us to the block
+ // containing the doc? yet assert false trips ... i
+ // think because if you advance w/o having done a
+ // nextDoc yet()... can we assert/remove this?
if (docBufferUpto == blockSize) {
- // nocommit hmm skip freq? but: we don't ever
- // scan over more than one block?
refillDocs();
}
accum += docDeltaBuffer[docBufferUpto];
@@ -842,6 +846,11 @@ public final class BlockPostingsReader e
if (docUpto == docFreq) {
return doc = NO_MORE_DOCS;
}
+ // nocommit: in theory we should not hit this? ie
+ // skipper should already have moved us to the block
+ // containing the doc? yet assert false trips ... i
+ // think because if you advance w/o having done a
+ // nextDoc yet()... can we assert/remove this?
if (docBufferUpto == blockSize) {
// nocommit hmm skip freq? but: we don't ever
// scan over more than one block?