You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2007/05/27 20:29:16 UTC

[jira] Updated: (DERBY-2707) Inadequate clean-up in many jdbc4 tests

     [ https://issues.apache.org/jira/browse/DERBY-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-2707:
--------------------------------------

    Attachment: jdbc4test.diff

Attaching patch which fixes the tearDown() method in the following files:
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/BlobTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/ClobTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/CallableStatementTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/TestJDBC40Exception.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/PreparedStatementTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/ResultSetTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/DataSourceTest.java

There is also a problem with tearDown() in LobStreamsTest and BlobSetMethodTest, but those tests are fixed in a patch that is attached to DERBY-2247, so I won't touch them here.

> Inadequate clean-up in many jdbc4 tests
> ---------------------------------------
>
>                 Key: DERBY-2707
>                 URL: https://issues.apache.org/jira/browse/DERBY-2707
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: jdbc4test.diff
>
>
> Many of the JUnit tests under the jdbc4 package don't implement tearDown() properly. Common problems:
>   * don't close JDBC objects
>   * don't call super.tearDown()
>   * don't null out instance variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.