You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 12:50:12 UTC

[GitHub] [spark] gengliangwang edited a comment on pull request #31771: [SPARK-34652][AVRO] Support SchemaRegistry in from_avro method

gengliangwang edited a comment on pull request #31771:
URL: https://github.com/apache/spark/pull/31771#issuecomment-792726114


   @blcksrx I don't think the implementation of this PR can work with Kafka + Avro + schema registry as https://docs.databricks.com/spark/latest/structured-streaming/avro-dataframe.html#example-with-schema-registry describes. I was hoping you realize the problem after you create unit tests for the use case.
   
   For what has done in this PR, it can be done by using the option `avroSchemaUrl` anyway. If your purpose is to get the latest Avro schema from the schema registry and use it on a stream of Avro format without schema-registry schema ID, there is no need to add a new API.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org