[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9803: [fix](brpc) Embed serialized request into the attachment and transmit it through http brpc

[GitBox <gi...@apache.org>]

xinyiZzz commented on code in PR #9803:
URL: https://github.com/apache/incubator-doris/pull/9803#discussion_r883235362


##########
be/src/util/proto_util.h:
##########
@@ -17,10 +17,17 @@
 
 #pragma once
 
-#include "util/stack_util.h"
-
 namespace doris {
 
+// When the tuple/block data is greater than 2G * 0.9, embed the tuple/block data
+// and the request serialization string in the attachment, and use "http" brpc.
+// "http"brpc requires that only one of request and attachment be non-null.
+//
+// 2G: In the default "baidu_std" brpcd, upper limit of the request and attachment length is 2G.
+// 0.9: Reserve a buffer of 0.1 for embedding request serialization strings, etc.
+constexpr size_t MIN_HTTP_BRPC_SIZE = (1ULL << 31) * 0.9;

Review Comment:
   It seems more difficult to understand



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org