[GitHub] [spark] viirya commented on a change in pull request #34631: [SPARK-37277][PYTHON][SQL] Support DayTimeIntervalType in pandas UDF and Arrow optimization

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #34631:
URL: https://github.com/apache/spark/pull/34631#discussion_r751944243



##########
File path: python/pyspark/sql/pandas/conversion.py
##########
@@ -225,7 +227,10 @@ def toPandas(self) -> "PandasDataFrameLike":
             else:
                 series = pdf[column_name]
 
-            if t is not None:
+            # No need to cast for empty series for timedelta.
+            should_check_timedelta = is_timedelta64_dtype(t) and len(pdf) == 0

Review comment:
       Are you actually meaning `len(pdf) != 0`? Or I miss-read the code/comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org