You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/16 23:55:22 UTC
Review Request 44939: GEODE-519 Make sure that membership port range
is available.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44939/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
test looks for port range of 3 port. Sometime that port is not available
thus now we check range of port before starting the test.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java fcaaa2d
Diff: https://reviews.apache.org/r/44939/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 44939: GEODE-519 Make sure that membership port
range is available.
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44939/#review123953
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java (line 330)
<https://reviews.apache.org/r/44939/#comment186275>
Better avoid using AvailablePort. We have seen problems before when using AvailablePort.
Can we try something similar to SocketCreator.createServerSocketUsingPortRange?
- Jianxia Chen
On March 16, 2016, 10:55 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44939/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:55 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> test looks for port range of 3 port. Sometime that port is not available
> thus now we check range of port before starting the test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java fcaaa2d
>
> Diff: https://reviews.apache.org/r/44939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 44939: GEODE-519 Make sure that membership port
range is available.
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44939/#review124599
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On March 16, 2016, 10:55 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44939/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:55 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> test looks for port range of 3 port. Sometime that port is not available
> thus now we check range of port before starting the test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java fcaaa2d
>
> Diff: https://reviews.apache.org/r/44939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 44939: GEODE-519 Make sure that membership port
range is available.
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44939/#review123947
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 16, 2016, 10:55 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44939/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:55 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> test looks for port range of 3 port. Sometime that port is not available
> thus now we check range of port before starting the test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java fcaaa2d
>
> Diff: https://reviews.apache.org/r/44939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>