You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Wei-Chiu Chuang (Jira)" <ji...@apache.org> on 2025/09/23 06:41:00 UTC
[jira] [Resolved] (HDDS-7566) Refactor TestRocksDBCheckpointDiffer class
[ https://issues.apache.org/jira/browse/HDDS-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wei-Chiu Chuang resolved HDDS-7566.
-----------------------------------
Fix Version/s: 2.1.0
Resolution: Fixed
> Refactor TestRocksDBCheckpointDiffer class
> ------------------------------------------
>
> Key: HDDS-7566
> URL: https://issues.apache.org/jira/browse/HDDS-7566
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Hemant Kumar
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.1.0
>
>
> Edit:
> The original issue meant to refactor the CompactionDag out of RocksDBCheckpointDiffer, which is already implemented. But the test is not.
> Therefore, moved CompactionDag specific tests from TestRocksDBCheckpointDiffer to a new TestCompactionDag class. This makes the tests more organized and easier to maintain.
> Below is the original issue.
> ---
> Currently, `RocksDBCheckpointDiffer` does lots of things (e.g. maintaining the DAG, implements RocksDB listener, diff two snapshots and probably remove/update of snapshot from DAG too) which makes it complicated and harder to test because of tight coupling with RocksDB.
> `RocksDbCheckpointDiffer` can be simplified by extracting out the DAG to new class `RocksDbCompactionDag` which maintains SST DAG in which you can add nodes & arcs, load the DAG from disk/DB, remove nodes and arcs, etc. DAG is independent of what we use to store compaction log (disk or RocksDB). We should be able to test all the functionality of `RocksDbCompactionDag` independently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org