You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/30 08:00:31 UTC
[GitHub] [ozone] adoroszlai commented on a change in pull request #1839: HDDS-4737. Add ModifierOrder to checkstyle rules
adoroszlai commented on a change in pull request #1839:
URL: https://github.com/apache/ozone/pull/1839#discussion_r567214527
##########
File path: pom.xml
##########
@@ -1974,6 +1974,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<suppressionsLocation>hadoop-hdds/dev-support/checkstyle/suppressions.xml</suppressionsLocation>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<failOnViolation>false</failOnViolation>
+ <consoleOutput>true</consoleOutput>
Review comment:
I'd rather not add this. Errors are already printed by `checkstyle:check`, now they appear twice:
```
08:52:48,115 [INFO] --- maven-checkstyle-plugin:3.1.0:check (default-cli) @ hadoop-hdds-common ---
08:52:48,248 [INFO] Starting audit...
[ERROR] hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:52:17: 'static' modifier out of order with the JLS suggestions. [ModifierOrder]
[ERROR] hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:52:31: Name 'uuidString' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:83: Line is longer than 80 characters (found 290). [LineLength]
Audit done.
08:52:48,250 [INFO] There are 3 errors reported by Checkstyle 8.29 with hadoop-hdds/dev-support/checkstyle/checkstyle.xml ruleset.
08:52:48,252 [ERROR] src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:[52,17] (modifier) ModifierOrder: 'static' modifier out of order with the JLS suggestions.
08:52:48,252 [ERROR] src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:[52,31] (naming) ConstantName: Name 'uuidString' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
08:52:48,253 [ERROR] src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:[83] (sizes) LineLength: Line is longer than 80 characters (found 290).
08:52:48,253 [WARNING] checkstyle:check violations detected but failOnViolation set to false
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org