[GitHub] [flink] wuchong commented on a change in pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #14468:
URL: https://github.com/apache/flink/pull/14468#discussion_r548414934



##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java
##########
@@ -316,4 +338,39 @@ public void testReadingFromChangelogSource() throws Exception {
 			Row.of("user4", "Tina", "tina@gmail.com", new BigDecimal("11.30"), new BigDecimal("22.60"))
 		}, DB_URL, USER_TABLE, new String[]{"user_id", "user_name", "email", "balance", "balance2"});
 	}
+
+	@Test
+	public void testCheckpoint() throws Exception {

Review comment:
       Rename to `testFlushBufferWhenCheckpoint` to make the test purpose more explicitly.

##########
File path: flink-connectors/flink-connector-jdbc/pom.xml
##########
@@ -109,6 +109,14 @@ under the License.
 
 		<!-- Postgres test dependencies -->
 
+		<dependency>

Review comment:
       Move this after comment `<!-- test dependencies -->` .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org