[jira] Commented: (AXIS2-4011) OMChildrenIterator based on local name has bug in isEqual() method

["Joe Ruth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720307#action_12720307 ] 

Joe Ruth commented on AXIS2-4011:
---------------------------------

I'm not quite sure I'd call this minor, as it makes usage of OMElement suspect.  I was using this method in a fairly complex program, and mistakenly had faith that this class behaved correctly.  A lot of wasted time thinking I was doing something incorrect.

Please fix this, it should be a trivial fix.

> OMChildrenIterator based on local name has bug in isEqual() method
> ------------------------------------------------------------------
>
>                 Key: AXIS2-4011
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4011
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: om
>    Affects Versions: 1.4.1
>            Reporter: Christian Kloner
>            Priority: Minor
>             Fix For: nightly
>
>
> The invocation of OMElement#getChildrenWithLocalName(String) does not work as expected cause the underlying OMChildrenIterator implementation OMChildrenLocalNameIterator has bug in method isEqual(QName, QName). It contains the following code:
> public boolean isEqual(QName searchQName, QName currentQName) {
>            return searchQName.getLocalPart().equals(searchQName.getLocalPart());
> }
> This should be changed to
> currentQName.getLocalPart().equals(searchQName.getLocalPart())

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.