[GitHub] [incubator-nuttx] patacongo opened a new pull request #106: tools/nxstyle.c: Correct false alarm detection

[GitBox <gi...@apache.org>]

patacongo opened a new pull request #106: tools/nxstyle.c:  Correct false alarm detection
URL: https://github.com/apache/incubator-nuttx/pull/106
 
 
   Commit cf5d17f7959a593b87b7d624a8ac63f241f8cd85 added logic to detect #define pre-processor definitions outside of the "Pre-processor Definitions" file section.  That commit was verified against numerous .c source files.  But not against any .h header files.
   
   When run against a header file, that change causes a false alarm warning like:
   
     file:line:pos: warning: #define outside of 'Pre-processor Definitions' section
   
   That is caused the idempotence, guard definition that must appear in the header file BEFORE the first file section.
   
   This commit adds logic to nxstyle to ignore pre-processor definitions in header files that occur before the first file section is encountered.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 merged pull request #106: tools/nxstyle.c: Correct false alarm detection

[GitBox <gi...@apache.org>]

Ouss4 merged pull request #106: tools/nxstyle.c:  Correct false alarm detection
URL: https://github.com/apache/incubator-nuttx/pull/106
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services