You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/08 10:28:29 UTC
[GitHub] [incubator-yunikorn-k8shim] kingamarton opened a new pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
kingamarton opened a new pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7c25f8747ef155d0eab78e714cf74f19793edcd6?el=desc) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 61.15% 58.23% -2.92%
==========================================
Files 33 33
Lines 4224 2931 -1293
==========================================
- Hits 2583 1707 -876
+ Misses 1537 1152 -385
+ Partials 104 72 -32
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (-75.66%)` | :arrow_down: |
| [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (-74.79%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-21.12%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-18.01%)` | :arrow_down: |
| [pkg/common/events/event\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvZXZlbnRfaGVscGVyLmdv) | `0.00% <0.00%> (-17.65%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `63.79% <0.00%> (-17.61%)` | :arrow_down: |
| [pkg/shim/scheduler\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX2V2ZW50cy5nbw==) | `66.66% <0.00%> (-11.91%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.13% <0.00%> (-4.99%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.35% <0.00%> (-1.86%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.55% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=footer). Last update [7c25f87...0fe2c7a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton closed pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
kingamarton closed pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7c25f8747ef155d0eab78e714cf74f19793edcd6?el=desc) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 61.15% 58.23% -2.92%
==========================================
Files 33 33
Lines 4224 2931 -1293
==========================================
- Hits 2583 1707 -876
+ Misses 1537 1152 -385
+ Partials 104 72 -32
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (-75.66%)` | :arrow_down: |
| [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (-74.79%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-21.12%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-18.01%)` | :arrow_down: |
| [pkg/common/events/event\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvZXZlbnRfaGVscGVyLmdv) | `0.00% <0.00%> (-17.65%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `63.79% <0.00%> (-17.61%)` | :arrow_down: |
| [pkg/shim/scheduler\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX2V2ZW50cy5nbw==) | `66.66% <0.00%> (-11.91%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.13% <0.00%> (-4.99%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.35% <0.00%> (-1.86%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.55% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=footer). Last update [7c25f87...2fc45e5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#discussion_r502079728
##########
File path: pkg/client/apifactory.go
##########
@@ -203,6 +206,10 @@ func (s *APIFactory) Start() {
// launch clients
if !s.IsTestingMode() {
s.clients.Run(s.stopChan)
+ if err := s.WaitForSync(); err != nil {
Review comment:
We already know we're not in test mode why are we not calling `s.clients.WaitForSync(time.Second, 30*time.Second)` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7c25f8747ef155d0eab78e714cf74f19793edcd6?el=desc) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 61.15% 58.23% -2.92%
==========================================
Files 33 33
Lines 4224 2931 -1293
==========================================
- Hits 2583 1707 -876
+ Misses 1537 1152 -385
+ Partials 104 72 -32
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (-75.66%)` | :arrow_down: |
| [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (-74.79%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-21.12%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-18.01%)` | :arrow_down: |
| [pkg/common/events/event\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvZXZlbnRfaGVscGVyLmdv) | `0.00% <0.00%> (-17.65%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `63.79% <0.00%> (-17.61%)` | :arrow_down: |
| [pkg/shim/scheduler\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX2V2ZW50cy5nbw==) | `66.66% <0.00%> (-11.91%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.13% <0.00%> (-4.99%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.35% <0.00%> (-1.86%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.55% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=footer). Last update [7c25f87...0fe2c7a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#discussion_r502079728
##########
File path: pkg/client/apifactory.go
##########
@@ -203,6 +206,10 @@ func (s *APIFactory) Start() {
// launch clients
if !s.IsTestingMode() {
s.clients.Run(s.stopChan)
+ if err := s.WaitForSync(); err != nil {
Review comment:
We already know we're not in test mode why are we not calling `s.clients.WaitForSync(time.Second, 30*time.Second)` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7c25f8747ef155d0eab78e714cf74f19793edcd6?el=desc) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 61.15% 58.23% -2.92%
==========================================
Files 33 33
Lines 4224 2931 -1293
==========================================
- Hits 2583 1707 -876
+ Misses 1537 1152 -385
+ Partials 104 72 -32
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (-75.66%)` | :arrow_down: |
| [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (-74.79%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-21.12%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-18.01%)` | :arrow_down: |
| [pkg/common/events/event\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvZXZlbnRfaGVscGVyLmdv) | `0.00% <0.00%> (-17.65%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `63.79% <0.00%> (-17.61%)` | :arrow_down: |
| [pkg/shim/scheduler\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX2V2ZW50cy5nbw==) | `66.66% <0.00%> (-11.91%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.13% <0.00%> (-4.99%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.35% <0.00%> (-1.86%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.55% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=footer). Last update [7c25f87...2fc45e5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#discussion_r502306185
##########
File path: pkg/client/apifactory.go
##########
@@ -203,6 +206,10 @@ func (s *APIFactory) Start() {
// launch clients
if !s.IsTestingMode() {
s.clients.Run(s.stopChan)
+ if err := s.WaitForSync(); err != nil {
Review comment:
Changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7c25f8747ef155d0eab78e714cf74f19793edcd6?el=desc) will **decrease** coverage by `2.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 61.15% 58.23% -2.92%
==========================================
Files 33 33
Lines 4224 2931 -1293
==========================================
- Hits 2583 1707 -876
+ Misses 1537 1152 -385
+ Partials 104 72 -32
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (-75.66%)` | :arrow_down: |
| [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (-74.79%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-21.12%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-18.01%)` | :arrow_down: |
| [pkg/common/events/event\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvZXZlbnRfaGVscGVyLmdv) | `0.00% <0.00%> (-17.65%)` | :arrow_down: |
| [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `63.79% <0.00%> (-17.61%)` | :arrow_down: |
| [pkg/shim/scheduler\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX2V2ZW50cy5nbw==) | `66.66% <0.00%> (-11.91%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.13% <0.00%> (-4.99%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.35% <0.00%> (-1.86%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.55% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=footer). Last update [7c25f87...2fc45e5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#issuecomment-705655458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#discussion_r502306185
##########
File path: pkg/client/apifactory.go
##########
@@ -203,6 +206,10 @@ func (s *APIFactory) Start() {
// launch clients
if !s.IsTestingMode() {
s.clients.Run(s.stopChan)
+ if err := s.WaitForSync(); err != nil {
Review comment:
Changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org