[GitHub] [cloudstack] shwstppr opened a new pull request #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

[GitBox <gi...@apache.org>]

shwstppr opened a new pull request #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints
URL: https://github.com/apache/cloudstack/pull/3245
 
 
   ## Description
   **Problem**: Custom compute offering does not allow setting min and max values for CPU and VRAM for custom VMs. 
   
   **Root Cause**: Custom compute offerings cannot be created with a given range of CPU number and memory instead it allows only fixed values. 
   
   **Solution**: createServiceOffering API has been modified to allow setting a defined range for CPU number and memory. Also, UI form for compute offering creation is provided with a new field named 'compute offering type’ with values - Fixed, Custom Constrained, Custom Constrained. It will allow creation of compute offerings either with a fixed CPU speed and memory for fixed compute offering, or with a range of CPU number and memory range for custom constrained compute offering or without predefined CPU number, CPU speed and memory for custom unconstrained compute offering. 
   
   To allow user to set CPU number, CPU speed and memory during VM deployment, UI form for VM deployment has been modified to provide controls to change these values. These controls are depicted in screenshots below for custom constrained and custom unconstrained compute offering types. 
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Create compute offering form
   ![Screenshot from 2019-03-12 17-32-13](https://user-images.githubusercontent.com/153340/54267506-5a620280-459f-11e9-8aa6-01e1cf98f3f2.png)
   ![Screenshot from 2019-03-12 17-32-17](https://user-images.githubusercontent.com/153340/54267507-5a620280-459f-11e9-826e-baebb79d32d5.png)
   ![Screenshot from 2019-03-12 17-32-22](https://user-images.githubusercontent.com/153340/54267508-5afa9900-459f-11e9-807a-614b7c104323.png)
   
   VM deployment form
   ![Screenshot from 2019-03-12 17-43-52](https://user-images.githubusercontent.com/153340/54267533-677ef180-459f-11e9-94ed-b53130b2c2d4.png)
   ![Screenshot from 2019-03-12 17-44-01](https://user-images.githubusercontent.com/153340/54267534-677ef180-459f-11e9-8541-bb8869662caf.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services