You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:30:59 UTC

[GitHub] [apisix] worldwonderer commented on pull request #7168: fix(proxy-cache): allow nil ctx vars in cache key

worldwonderer commented on PR #7168:
URL: https://github.com/apache/apisix/pull/7168#issuecomment-1141605845

   > Hi @worldwonderer , thank you for your contribution.
   > 
   > The test case is wrongly written.
   > 
   > ```
   > --- request
   > GET /hello
   > ```
   > 
   > will not hit `location /t`.
   > 
   > you can ref to: https://github.com/apache/apisix/blob/master/t/plugin/proxy-cache/disk.t#L318-L367
   
   Thanks for your reminder. I understand the usage of test cases now. First, request /t will create route and request /hello will goto the created route? I pushed new commit, plz trigger CI and try again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org