You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by Suneel Marthi <sm...@apache.org> on 2016/07/22 20:16:08 UTC
Minimum Maven version
Travis presently is set up with Maven 3.2.5. Consider going with a minimum
of 3.3.3 for Pirk, most other projects are at maven 3.3.9.
I have the change for that as part of the PR for Pirk-10.
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
Thanks Joe, that was my thinking too.
someone please configure Travis to Maven 3.3.9. Its at 3.2.5 now.
On Fri, Jul 22, 2016 at 5:13 PM, Joe Witt <jo...@gmail.com> wrote:
> Team,
>
> Within NiFi we went with the "oldest version of Maven we could fairly
> easily support" approach. I really wish we had not.
>
> As a new project you have one shot to set some of the fundamentals
> down right such as the JVM you're tied to or the Maven build
> environment and such. I recommend, picking the most forward leaning
> one you think you'll need. It is really easy to install the latest
> version of Maven but it is really non-trivial if you're doing
> interesting things with Maven to maintain support over long periods of
> time for behaviors of older versions.
>
> I'd seriously recommend you take the latest Maven release and call
> that the Maven version. That is purely a recommendation. I'll help
> whatever path is the consensus.
>
> Thanks
> Joe
>
> On Fri, Jul 22, 2016 at 5:12 PM, Suneel Marthi <sm...@apache.org> wrote:
> > Well most Apache projects r now at Maven >= 3.3.3.
> >
> > Spark is at 3.3.9.
> >
> > So why stick with 3.2.5 ?
> >
> > On Fri, Jul 22, 2016 at 5:10 PM, Tim Ellison <t....@gmail.com>
> wrote:
> >
> >> My understanding is that the change to Java 8 was because earlier
> versions
> >> are now end of life, and Pirk's dependencies are moving to Java 8.
> >>
> >> What is the driver to move up to a later Maven version?
> >>
> >> I guess as a principle, specifying the lowest possible version of the
> >> project's dependencies in the supported range allows for the broadest
> range
> >> of target systems.
> >>
> >> On 22 July 2016 at 21:16, Suneel Marthi <sm...@apache.org> wrote:
> >>
> >> > Travis presently is set up with Maven 3.2.5. Consider going with a
> >> minimum
> >> > of 3.3.3 for Pirk, most other projects are at maven 3.3.9.
> >> >
> >> > I have the change for that as part of the PR for Pirk-10.
> >> >
> >>
>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
That fixed it Joe, it was those XML parser warnings that were failing RAT.
We are indeed good now.
Thanks again.
On Fri, Jul 22, 2016 at 10:16 PM, Joe Witt <jo...@gmail.com> wrote:
> If you go here
> https://travis-ci.org/apache/incubator-pirk
>
> You can then click on 'build history'
> https://travis-ci.org/apache/incubator-pirk/builds
>
> You can then look for the failed/master build which mentions rat
> https://travis-ci.org/apache/incubator-pirk/builds/145628437
>
> Then click the jdk8 build
> https://travis-ci.org/apache/incubator-pirk/jobs/145628438
>
> Then view the raw log
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/145628438/log.txt
>
> It does seem there is a single file it is complaining about. It
> should print the issues on the log as well but I'm not seeing them.
> There are some warning about xml parsing though that may be a factor
> too.
>
> I recommend changing the pirk pom section for RAT to be very similar
> to nifi. Links provided
> https://github.com/apache/nifi/blob/master/pom.xml#L1636-L1662
> https://github.com/apache/incubator-pirk/blob/master/pom.xml#L257-L268
>
> That will address the XML parsing issue I believe and should also
> address the travis.yml header issue.
>
> Thanks
> Joe
>
> On Fri, Jul 22, 2016 at 10:06 PM, Suneel Marthi <su...@gmail.com>
> wrote:
> > how do i access that?
> >
> > On Fri, Jul 22, 2016 at 10:05 PM, Joe Witt <jo...@gmail.com> wrote:
> >
> >> Did you look in /home/travis/build/apache/incubator-pirk/target/rat.txt?
> >>
> >> The RAT reports are generally pretty good I have found.
> >>
> >> On Fri, Jul 22, 2016 at 10:04 PM, Suneel Marthi <
> suneel.marthi@gmail.com>
> >> wrote:
> >> > Could it be that the .travis.yml needs a license header, that's the
> only
> >> > one without a header.
> >> >
> >> >
> >> >
> >> > On Fri, Jul 22, 2016 at 9:41 PM, Joe Witt <jo...@gmail.com> wrote:
> >> >
> >> >> Suneel
> >> >>
> >> >> It is probably a good idea to keep it there because it can really
> help
> >> >> with automating some of the checks as people put in PRs.
> >> >>
> >> >> I'm happy to help do licensing/header hunting soon.
> >> >>
> >> >> Thanks
> >> >> Joe
> >> >>
> >> >> On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <
> suneel.marthi@gmail.com
> >> >
> >> >> wrote:
> >> >> > We r good now, I disabled the rat check to get past the build
> >> failure, i
> >> >> > guess we don't need that for travis, do we?
> >> >> >
> >> >> > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <
> >> suneel.marthi@gmail.com>
> >> >> > wrote:
> >> >> >
> >> >> >> Getting a travis build error for RAT, any ideas ? I am not seeing
> >> this
> >> >> >> locally.
> >> >> >>
> >> >> >> [ERROR] Failed to execute goal
> >> >> org.apache.rat:apache-rat-plugin:0.11:check
> >> >> >> (default) on project pirk: Too many files with unapproved
> license: 1
> >> See
> >> >> >> RAT report in:
> >> /home/travis/build/apache/incubator-pirk/target/rat.txt
> >> >> ->
> >> >> >> [Help 1]
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <
> >> suneel.marthi@gmail.com
> >> >> >
> >> >> >> wrote:
> >> >> >>
> >> >> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this
> >> >> change.
> >> >> >>>
> >> >> >>> OK with @here ?
> >> >> >>>
> >> >> >>>
> >> >> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <
> >> >> suneel.marthi@gmail.com>
> >> >> >>> wrote:
> >> >> >>>
> >> >> >>>> Let's go with Option 1, i can modify .travis.yml to account for
> >> Maven
> >> >> >>>> 3.3x
> >> >> >>>>
> >> >> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <
> >> t.p.ellison@gmail.com>
> >> >> >>>> wrote:
> >> >> >>>>
> >> >> >>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
> >> >> >>>>>
> >> >> >>>>> > Within NiFi we went with the "oldest version of Maven we
> could
> >> >> fairly
> >> >> >>>>> > easily support" approach. I really wish we had not.
> >> >> >>>>> >
> >> >> >>>>> > As a new project you have one shot to set some of the
> >> fundamentals
> >> >> >>>>> > down right such as the JVM you're tied to or the Maven build
> >> >> >>>>> > environment and such. I recommend, picking the most forward
> >> >> leaning
> >> >> >>>>> > one you think you'll need. It is really easy to install the
> >> latest
> >> >> >>>>> > version of Maven
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>> Just checking I'm not missing something about installing the
> >> latest
> >> >> >>>>> version
> >> >> >>>>> of Maven on Travis.
> >> >> >>>>>
> >> >> >>>>> A quick search shows we need to either script the download of a
> >> later
> >> >> >>>>> version [1], or a seemingly better option is to define the
> entire
> >> >> build
> >> >> >>>>> env
> >> >> >>>>> using Docker[2].
> >> >> >>>>>
> >> >> >>>>> [1]
> >> >> >>>>>
> >> >> >>>>>
> >> >>
> >>
> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
> >> >> >>>>> [2]
> >> >> >>>>>
> >> >> >>>>>
> >> >>
> >>
> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
> >> >> >>>>>
> >> >> >>>>> Regards,
> >> >> >>>>> Tim
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>> > but it is really non-trivial if you're doing
> >> >> >>>>> > interesting things with Maven to maintain support over long
> >> >> periods of
> >> >> >>>>> > time for behaviors of older versions.
> >> >> >>>>> >
> >> >> >>>>> > I'd seriously recommend you take the latest Maven release and
> >> call
> >> >> >>>>> > that the Maven version. That is purely a recommendation.
> I'll
> >> >> help
> >> >> >>>>> > whatever path is the consensus.
> >> >> >>>>> >
> >> >> >>>>>
> >> >> >>>>
> >> >> >>>>
> >> >> >>>
> >> >> >>
> >> >>
> >>
>
Re: Minimum Maven version
Posted by Joe Witt <jo...@gmail.com>.
If you go here
https://travis-ci.org/apache/incubator-pirk
You can then click on 'build history'
https://travis-ci.org/apache/incubator-pirk/builds
You can then look for the failed/master build which mentions rat
https://travis-ci.org/apache/incubator-pirk/builds/145628437
Then click the jdk8 build
https://travis-ci.org/apache/incubator-pirk/jobs/145628438
Then view the raw log
https://s3.amazonaws.com/archive.travis-ci.org/jobs/145628438/log.txt
It does seem there is a single file it is complaining about. It
should print the issues on the log as well but I'm not seeing them.
There are some warning about xml parsing though that may be a factor
too.
I recommend changing the pirk pom section for RAT to be very similar
to nifi. Links provided
https://github.com/apache/nifi/blob/master/pom.xml#L1636-L1662
https://github.com/apache/incubator-pirk/blob/master/pom.xml#L257-L268
That will address the XML parsing issue I believe and should also
address the travis.yml header issue.
Thanks
Joe
On Fri, Jul 22, 2016 at 10:06 PM, Suneel Marthi <su...@gmail.com> wrote:
> how do i access that?
>
> On Fri, Jul 22, 2016 at 10:05 PM, Joe Witt <jo...@gmail.com> wrote:
>
>> Did you look in /home/travis/build/apache/incubator-pirk/target/rat.txt?
>>
>> The RAT reports are generally pretty good I have found.
>>
>> On Fri, Jul 22, 2016 at 10:04 PM, Suneel Marthi <su...@gmail.com>
>> wrote:
>> > Could it be that the .travis.yml needs a license header, that's the only
>> > one without a header.
>> >
>> >
>> >
>> > On Fri, Jul 22, 2016 at 9:41 PM, Joe Witt <jo...@gmail.com> wrote:
>> >
>> >> Suneel
>> >>
>> >> It is probably a good idea to keep it there because it can really help
>> >> with automating some of the checks as people put in PRs.
>> >>
>> >> I'm happy to help do licensing/header hunting soon.
>> >>
>> >> Thanks
>> >> Joe
>> >>
>> >> On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <suneel.marthi@gmail.com
>> >
>> >> wrote:
>> >> > We r good now, I disabled the rat check to get past the build
>> failure, i
>> >> > guess we don't need that for travis, do we?
>> >> >
>> >> > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <
>> suneel.marthi@gmail.com>
>> >> > wrote:
>> >> >
>> >> >> Getting a travis build error for RAT, any ideas ? I am not seeing
>> this
>> >> >> locally.
>> >> >>
>> >> >> [ERROR] Failed to execute goal
>> >> org.apache.rat:apache-rat-plugin:0.11:check
>> >> >> (default) on project pirk: Too many files with unapproved license: 1
>> See
>> >> >> RAT report in:
>> /home/travis/build/apache/incubator-pirk/target/rat.txt
>> >> ->
>> >> >> [Help 1]
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <
>> suneel.marthi@gmail.com
>> >> >
>> >> >> wrote:
>> >> >>
>> >> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this
>> >> change.
>> >> >>>
>> >> >>> OK with @here ?
>> >> >>>
>> >> >>>
>> >> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <
>> >> suneel.marthi@gmail.com>
>> >> >>> wrote:
>> >> >>>
>> >> >>>> Let's go with Option 1, i can modify .travis.yml to account for
>> Maven
>> >> >>>> 3.3x
>> >> >>>>
>> >> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <
>> t.p.ellison@gmail.com>
>> >> >>>> wrote:
>> >> >>>>
>> >> >>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>> >> >>>>>
>> >> >>>>> > Within NiFi we went with the "oldest version of Maven we could
>> >> fairly
>> >> >>>>> > easily support" approach. I really wish we had not.
>> >> >>>>> >
>> >> >>>>> > As a new project you have one shot to set some of the
>> fundamentals
>> >> >>>>> > down right such as the JVM you're tied to or the Maven build
>> >> >>>>> > environment and such. I recommend, picking the most forward
>> >> leaning
>> >> >>>>> > one you think you'll need. It is really easy to install the
>> latest
>> >> >>>>> > version of Maven
>> >> >>>>>
>> >> >>>>>
>> >> >>>>> Just checking I'm not missing something about installing the
>> latest
>> >> >>>>> version
>> >> >>>>> of Maven on Travis.
>> >> >>>>>
>> >> >>>>> A quick search shows we need to either script the download of a
>> later
>> >> >>>>> version [1], or a seemingly better option is to define the entire
>> >> build
>> >> >>>>> env
>> >> >>>>> using Docker[2].
>> >> >>>>>
>> >> >>>>> [1]
>> >> >>>>>
>> >> >>>>>
>> >>
>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>> >> >>>>> [2]
>> >> >>>>>
>> >> >>>>>
>> >>
>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>> >> >>>>>
>> >> >>>>> Regards,
>> >> >>>>> Tim
>> >> >>>>>
>> >> >>>>>
>> >> >>>>>
>> >> >>>>> > but it is really non-trivial if you're doing
>> >> >>>>> > interesting things with Maven to maintain support over long
>> >> periods of
>> >> >>>>> > time for behaviors of older versions.
>> >> >>>>> >
>> >> >>>>> > I'd seriously recommend you take the latest Maven release and
>> call
>> >> >>>>> > that the Maven version. That is purely a recommendation. I'll
>> >> help
>> >> >>>>> > whatever path is the consensus.
>> >> >>>>> >
>> >> >>>>>
>> >> >>>>
>> >> >>>>
>> >> >>>
>> >> >>
>> >>
>>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
how do i access that?
On Fri, Jul 22, 2016 at 10:05 PM, Joe Witt <jo...@gmail.com> wrote:
> Did you look in /home/travis/build/apache/incubator-pirk/target/rat.txt?
>
> The RAT reports are generally pretty good I have found.
>
> On Fri, Jul 22, 2016 at 10:04 PM, Suneel Marthi <su...@gmail.com>
> wrote:
> > Could it be that the .travis.yml needs a license header, that's the only
> > one without a header.
> >
> >
> >
> > On Fri, Jul 22, 2016 at 9:41 PM, Joe Witt <jo...@gmail.com> wrote:
> >
> >> Suneel
> >>
> >> It is probably a good idea to keep it there because it can really help
> >> with automating some of the checks as people put in PRs.
> >>
> >> I'm happy to help do licensing/header hunting soon.
> >>
> >> Thanks
> >> Joe
> >>
> >> On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <suneel.marthi@gmail.com
> >
> >> wrote:
> >> > We r good now, I disabled the rat check to get past the build
> failure, i
> >> > guess we don't need that for travis, do we?
> >> >
> >> > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <
> suneel.marthi@gmail.com>
> >> > wrote:
> >> >
> >> >> Getting a travis build error for RAT, any ideas ? I am not seeing
> this
> >> >> locally.
> >> >>
> >> >> [ERROR] Failed to execute goal
> >> org.apache.rat:apache-rat-plugin:0.11:check
> >> >> (default) on project pirk: Too many files with unapproved license: 1
> See
> >> >> RAT report in:
> /home/travis/build/apache/incubator-pirk/target/rat.txt
> >> ->
> >> >> [Help 1]
> >> >>
> >> >>
> >> >>
> >> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <
> suneel.marthi@gmail.com
> >> >
> >> >> wrote:
> >> >>
> >> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this
> >> change.
> >> >>>
> >> >>> OK with @here ?
> >> >>>
> >> >>>
> >> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <
> >> suneel.marthi@gmail.com>
> >> >>> wrote:
> >> >>>
> >> >>>> Let's go with Option 1, i can modify .travis.yml to account for
> Maven
> >> >>>> 3.3x
> >> >>>>
> >> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <
> t.p.ellison@gmail.com>
> >> >>>> wrote:
> >> >>>>
> >> >>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
> >> >>>>>
> >> >>>>> > Within NiFi we went with the "oldest version of Maven we could
> >> fairly
> >> >>>>> > easily support" approach. I really wish we had not.
> >> >>>>> >
> >> >>>>> > As a new project you have one shot to set some of the
> fundamentals
> >> >>>>> > down right such as the JVM you're tied to or the Maven build
> >> >>>>> > environment and such. I recommend, picking the most forward
> >> leaning
> >> >>>>> > one you think you'll need. It is really easy to install the
> latest
> >> >>>>> > version of Maven
> >> >>>>>
> >> >>>>>
> >> >>>>> Just checking I'm not missing something about installing the
> latest
> >> >>>>> version
> >> >>>>> of Maven on Travis.
> >> >>>>>
> >> >>>>> A quick search shows we need to either script the download of a
> later
> >> >>>>> version [1], or a seemingly better option is to define the entire
> >> build
> >> >>>>> env
> >> >>>>> using Docker[2].
> >> >>>>>
> >> >>>>> [1]
> >> >>>>>
> >> >>>>>
> >>
> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
> >> >>>>> [2]
> >> >>>>>
> >> >>>>>
> >>
> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
> >> >>>>>
> >> >>>>> Regards,
> >> >>>>> Tim
> >> >>>>>
> >> >>>>>
> >> >>>>>
> >> >>>>> > but it is really non-trivial if you're doing
> >> >>>>> > interesting things with Maven to maintain support over long
> >> periods of
> >> >>>>> > time for behaviors of older versions.
> >> >>>>> >
> >> >>>>> > I'd seriously recommend you take the latest Maven release and
> call
> >> >>>>> > that the Maven version. That is purely a recommendation. I'll
> >> help
> >> >>>>> > whatever path is the consensus.
> >> >>>>> >
> >> >>>>>
> >> >>>>
> >> >>>>
> >> >>>
> >> >>
> >>
>
Re: Minimum Maven version
Posted by Joe Witt <jo...@gmail.com>.
Did you look in /home/travis/build/apache/incubator-pirk/target/rat.txt?
The RAT reports are generally pretty good I have found.
On Fri, Jul 22, 2016 at 10:04 PM, Suneel Marthi <su...@gmail.com> wrote:
> Could it be that the .travis.yml needs a license header, that's the only
> one without a header.
>
>
>
> On Fri, Jul 22, 2016 at 9:41 PM, Joe Witt <jo...@gmail.com> wrote:
>
>> Suneel
>>
>> It is probably a good idea to keep it there because it can really help
>> with automating some of the checks as people put in PRs.
>>
>> I'm happy to help do licensing/header hunting soon.
>>
>> Thanks
>> Joe
>>
>> On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <su...@gmail.com>
>> wrote:
>> > We r good now, I disabled the rat check to get past the build failure, i
>> > guess we don't need that for travis, do we?
>> >
>> > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <su...@gmail.com>
>> > wrote:
>> >
>> >> Getting a travis build error for RAT, any ideas ? I am not seeing this
>> >> locally.
>> >>
>> >> [ERROR] Failed to execute goal
>> org.apache.rat:apache-rat-plugin:0.11:check
>> >> (default) on project pirk: Too many files with unapproved license: 1 See
>> >> RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt
>> ->
>> >> [Help 1]
>> >>
>> >>
>> >>
>> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <suneel.marthi@gmail.com
>> >
>> >> wrote:
>> >>
>> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this
>> change.
>> >>>
>> >>> OK with @here ?
>> >>>
>> >>>
>> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <
>> suneel.marthi@gmail.com>
>> >>> wrote:
>> >>>
>> >>>> Let's go with Option 1, i can modify .travis.yml to account for Maven
>> >>>> 3.3x
>> >>>>
>> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
>> >>>> wrote:
>> >>>>
>> >>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>> >>>>>
>> >>>>> > Within NiFi we went with the "oldest version of Maven we could
>> fairly
>> >>>>> > easily support" approach. I really wish we had not.
>> >>>>> >
>> >>>>> > As a new project you have one shot to set some of the fundamentals
>> >>>>> > down right such as the JVM you're tied to or the Maven build
>> >>>>> > environment and such. I recommend, picking the most forward
>> leaning
>> >>>>> > one you think you'll need. It is really easy to install the latest
>> >>>>> > version of Maven
>> >>>>>
>> >>>>>
>> >>>>> Just checking I'm not missing something about installing the latest
>> >>>>> version
>> >>>>> of Maven on Travis.
>> >>>>>
>> >>>>> A quick search shows we need to either script the download of a later
>> >>>>> version [1], or a seemingly better option is to define the entire
>> build
>> >>>>> env
>> >>>>> using Docker[2].
>> >>>>>
>> >>>>> [1]
>> >>>>>
>> >>>>>
>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>> >>>>> [2]
>> >>>>>
>> >>>>>
>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>> >>>>>
>> >>>>> Regards,
>> >>>>> Tim
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>> > but it is really non-trivial if you're doing
>> >>>>> > interesting things with Maven to maintain support over long
>> periods of
>> >>>>> > time for behaviors of older versions.
>> >>>>> >
>> >>>>> > I'd seriously recommend you take the latest Maven release and call
>> >>>>> > that the Maven version. That is purely a recommendation. I'll
>> help
>> >>>>> > whatever path is the consensus.
>> >>>>> >
>> >>>>>
>> >>>>
>> >>>>
>> >>>
>> >>
>>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
Could it be that the .travis.yml needs a license header, that's the only
one without a header.
On Fri, Jul 22, 2016 at 9:41 PM, Joe Witt <jo...@gmail.com> wrote:
> Suneel
>
> It is probably a good idea to keep it there because it can really help
> with automating some of the checks as people put in PRs.
>
> I'm happy to help do licensing/header hunting soon.
>
> Thanks
> Joe
>
> On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <su...@gmail.com>
> wrote:
> > We r good now, I disabled the rat check to get past the build failure, i
> > guess we don't need that for travis, do we?
> >
> > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <su...@gmail.com>
> > wrote:
> >
> >> Getting a travis build error for RAT, any ideas ? I am not seeing this
> >> locally.
> >>
> >> [ERROR] Failed to execute goal
> org.apache.rat:apache-rat-plugin:0.11:check
> >> (default) on project pirk: Too many files with unapproved license: 1 See
> >> RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt
> ->
> >> [Help 1]
> >>
> >>
> >>
> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <suneel.marthi@gmail.com
> >
> >> wrote:
> >>
> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this
> change.
> >>>
> >>> OK with @here ?
> >>>
> >>>
> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <
> suneel.marthi@gmail.com>
> >>> wrote:
> >>>
> >>>> Let's go with Option 1, i can modify .travis.yml to account for Maven
> >>>> 3.3x
> >>>>
> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
> >>>> wrote:
> >>>>
> >>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
> >>>>>
> >>>>> > Within NiFi we went with the "oldest version of Maven we could
> fairly
> >>>>> > easily support" approach. I really wish we had not.
> >>>>> >
> >>>>> > As a new project you have one shot to set some of the fundamentals
> >>>>> > down right such as the JVM you're tied to or the Maven build
> >>>>> > environment and such. I recommend, picking the most forward
> leaning
> >>>>> > one you think you'll need. It is really easy to install the latest
> >>>>> > version of Maven
> >>>>>
> >>>>>
> >>>>> Just checking I'm not missing something about installing the latest
> >>>>> version
> >>>>> of Maven on Travis.
> >>>>>
> >>>>> A quick search shows we need to either script the download of a later
> >>>>> version [1], or a seemingly better option is to define the entire
> build
> >>>>> env
> >>>>> using Docker[2].
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>>
> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
> >>>>> [2]
> >>>>>
> >>>>>
> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
> >>>>>
> >>>>> Regards,
> >>>>> Tim
> >>>>>
> >>>>>
> >>>>>
> >>>>> > but it is really non-trivial if you're doing
> >>>>> > interesting things with Maven to maintain support over long
> periods of
> >>>>> > time for behaviors of older versions.
> >>>>> >
> >>>>> > I'd seriously recommend you take the latest Maven release and call
> >>>>> > that the Maven version. That is purely a recommendation. I'll
> help
> >>>>> > whatever path is the consensus.
> >>>>> >
> >>>>>
> >>>>
> >>>>
> >>>
> >>
>
Re: Minimum Maven version
Posted by Joe Witt <jo...@gmail.com>.
Suneel
It is probably a good idea to keep it there because it can really help
with automating some of the checks as people put in PRs.
I'm happy to help do licensing/header hunting soon.
Thanks
Joe
On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <su...@gmail.com> wrote:
> We r good now, I disabled the rat check to get past the build failure, i
> guess we don't need that for travis, do we?
>
> On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <su...@gmail.com>
> wrote:
>
>> Getting a travis build error for RAT, any ideas ? I am not seeing this
>> locally.
>>
>> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
>> (default) on project pirk: Too many files with unapproved license: 1 See
>> RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt ->
>> [Help 1]
>>
>>
>>
>> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <su...@gmail.com>
>> wrote:
>>
>>> ... I am also gonna disable Jdk 7 jobs on travis as part of this change.
>>>
>>> OK with @here ?
>>>
>>>
>>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <su...@gmail.com>
>>> wrote:
>>>
>>>> Let's go with Option 1, i can modify .travis.yml to account for Maven
>>>> 3.3x
>>>>
>>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
>>>> wrote:
>>>>
>>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>>>>>
>>>>> > Within NiFi we went with the "oldest version of Maven we could fairly
>>>>> > easily support" approach. I really wish we had not.
>>>>> >
>>>>> > As a new project you have one shot to set some of the fundamentals
>>>>> > down right such as the JVM you're tied to or the Maven build
>>>>> > environment and such. I recommend, picking the most forward leaning
>>>>> > one you think you'll need. It is really easy to install the latest
>>>>> > version of Maven
>>>>>
>>>>>
>>>>> Just checking I'm not missing something about installing the latest
>>>>> version
>>>>> of Maven on Travis.
>>>>>
>>>>> A quick search shows we need to either script the download of a later
>>>>> version [1], or a seemingly better option is to define the entire build
>>>>> env
>>>>> using Docker[2].
>>>>>
>>>>> [1]
>>>>>
>>>>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>>>>> [2]
>>>>>
>>>>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>>>
>>>>>
>>>>> > but it is really non-trivial if you're doing
>>>>> > interesting things with Maven to maintain support over long periods of
>>>>> > time for behaviors of older versions.
>>>>> >
>>>>> > I'd seriously recommend you take the latest Maven release and call
>>>>> > that the Maven version. That is purely a recommendation. I'll help
>>>>> > whatever path is the consensus.
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
We r good now, I disabled the rat check to get past the build failure, i
guess we don't need that for travis, do we?
On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <su...@gmail.com>
wrote:
> Getting a travis build error for RAT, any ideas ? I am not seeing this
> locally.
>
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
> (default) on project pirk: Too many files with unapproved license: 1 See
> RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt ->
> [Help 1]
>
>
>
> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <su...@gmail.com>
> wrote:
>
>> ... I am also gonna disable Jdk 7 jobs on travis as part of this change.
>>
>> OK with @here ?
>>
>>
>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <su...@gmail.com>
>> wrote:
>>
>>> Let's go with Option 1, i can modify .travis.yml to account for Maven
>>> 3.3x
>>>
>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
>>> wrote:
>>>
>>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>>>>
>>>> > Within NiFi we went with the "oldest version of Maven we could fairly
>>>> > easily support" approach. I really wish we had not.
>>>> >
>>>> > As a new project you have one shot to set some of the fundamentals
>>>> > down right such as the JVM you're tied to or the Maven build
>>>> > environment and such. I recommend, picking the most forward leaning
>>>> > one you think you'll need. It is really easy to install the latest
>>>> > version of Maven
>>>>
>>>>
>>>> Just checking I'm not missing something about installing the latest
>>>> version
>>>> of Maven on Travis.
>>>>
>>>> A quick search shows we need to either script the download of a later
>>>> version [1], or a seemingly better option is to define the entire build
>>>> env
>>>> using Docker[2].
>>>>
>>>> [1]
>>>>
>>>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>>>> [2]
>>>>
>>>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>>>
>>>>
>>>> > but it is really non-trivial if you're doing
>>>> > interesting things with Maven to maintain support over long periods of
>>>> > time for behaviors of older versions.
>>>> >
>>>> > I'd seriously recommend you take the latest Maven release and call
>>>> > that the Maven version. That is purely a recommendation. I'll help
>>>> > whatever path is the consensus.
>>>> >
>>>>
>>>
>>>
>>
>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
Getting a travis build error for RAT, any ideas ? I am not seeing this
locally.
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
(default) on project pirk: Too many files with unapproved license: 1 See
RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt ->
[Help 1]
On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <su...@gmail.com>
wrote:
> ... I am also gonna disable Jdk 7 jobs on travis as part of this change.
>
> OK with @here ?
>
>
> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <su...@gmail.com>
> wrote:
>
>> Let's go with Option 1, i can modify .travis.yml to account for Maven 3.3x
>>
>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
>> wrote:
>>
>>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>>>
>>> > Within NiFi we went with the "oldest version of Maven we could fairly
>>> > easily support" approach. I really wish we had not.
>>> >
>>> > As a new project you have one shot to set some of the fundamentals
>>> > down right such as the JVM you're tied to or the Maven build
>>> > environment and such. I recommend, picking the most forward leaning
>>> > one you think you'll need. It is really easy to install the latest
>>> > version of Maven
>>>
>>>
>>> Just checking I'm not missing something about installing the latest
>>> version
>>> of Maven on Travis.
>>>
>>> A quick search shows we need to either script the download of a later
>>> version [1], or a seemingly better option is to define the entire build
>>> env
>>> using Docker[2].
>>>
>>> [1]
>>>
>>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>>> [2]
>>>
>>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>>>
>>> Regards,
>>> Tim
>>>
>>>
>>>
>>> > but it is really non-trivial if you're doing
>>> > interesting things with Maven to maintain support over long periods of
>>> > time for behaviors of older versions.
>>> >
>>> > I'd seriously recommend you take the latest Maven release and call
>>> > that the Maven version. That is purely a recommendation. I'll help
>>> > whatever path is the consensus.
>>> >
>>>
>>
>>
>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
... I am also gonna disable Jdk 7 jobs on travis as part of this change.
OK with @here ?
On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <su...@gmail.com>
wrote:
> Let's go with Option 1, i can modify .travis.yml to account for Maven 3.3x
>
> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com>
> wrote:
>
>> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>>
>> > Within NiFi we went with the "oldest version of Maven we could fairly
>> > easily support" approach. I really wish we had not.
>> >
>> > As a new project you have one shot to set some of the fundamentals
>> > down right such as the JVM you're tied to or the Maven build
>> > environment and such. I recommend, picking the most forward leaning
>> > one you think you'll need. It is really easy to install the latest
>> > version of Maven
>>
>>
>> Just checking I'm not missing something about installing the latest
>> version
>> of Maven on Travis.
>>
>> A quick search shows we need to either script the download of a later
>> version [1], or a seemingly better option is to define the entire build
>> env
>> using Docker[2].
>>
>> [1]
>>
>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
>> [2]
>>
>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>>
>> Regards,
>> Tim
>>
>>
>>
>> > but it is really non-trivial if you're doing
>> > interesting things with Maven to maintain support over long periods of
>> > time for behaviors of older versions.
>> >
>> > I'd seriously recommend you take the latest Maven release and call
>> > that the Maven version. That is purely a recommendation. I'll help
>> > whatever path is the consensus.
>> >
>>
>
>
Re: Minimum Maven version
Posted by Suneel Marthi <su...@gmail.com>.
Let's go with Option 1, i can modify .travis.yml to account for Maven 3.3x
On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <t....@gmail.com> wrote:
> On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
>
> > Within NiFi we went with the "oldest version of Maven we could fairly
> > easily support" approach. I really wish we had not.
> >
> > As a new project you have one shot to set some of the fundamentals
> > down right such as the JVM you're tied to or the Maven build
> > environment and such. I recommend, picking the most forward leaning
> > one you think you'll need. It is really easy to install the latest
> > version of Maven
>
>
> Just checking I'm not missing something about installing the latest version
> of Maven on Travis.
>
> A quick search shows we need to either script the download of a later
> version [1], or a seemingly better option is to define the entire build env
> using Docker[2].
>
> [1]
>
> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
> [2]
>
> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
>
> Regards,
> Tim
>
>
>
> > but it is really non-trivial if you're doing
> > interesting things with Maven to maintain support over long periods of
> > time for behaviors of older versions.
> >
> > I'd seriously recommend you take the latest Maven release and call
> > that the Maven version. That is purely a recommendation. I'll help
> > whatever path is the consensus.
> >
>
Re: Minimum Maven version
Posted by Tim Ellison <t....@gmail.com>.
On 22 July 2016 at 22:13, Joe Witt <jo...@gmail.com> wrote:
> Within NiFi we went with the "oldest version of Maven we could fairly
> easily support" approach. I really wish we had not.
>
> As a new project you have one shot to set some of the fundamentals
> down right such as the JVM you're tied to or the Maven build
> environment and such. I recommend, picking the most forward leaning
> one you think you'll need. It is really easy to install the latest
> version of Maven
Just checking I'm not missing something about installing the latest version
of Maven on Travis.
A quick search shows we need to either script the download of a later
version [1], or a seemingly better option is to define the entire build env
using Docker[2].
[1]
http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html
[2]
http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/
Regards,
Tim
> but it is really non-trivial if you're doing
> interesting things with Maven to maintain support over long periods of
> time for behaviors of older versions.
>
> I'd seriously recommend you take the latest Maven release and call
> that the Maven version. That is purely a recommendation. I'll help
> whatever path is the consensus.
>
Re: Minimum Maven version
Posted by Joe Witt <jo...@gmail.com>.
Team,
Within NiFi we went with the "oldest version of Maven we could fairly
easily support" approach. I really wish we had not.
As a new project you have one shot to set some of the fundamentals
down right such as the JVM you're tied to or the Maven build
environment and such. I recommend, picking the most forward leaning
one you think you'll need. It is really easy to install the latest
version of Maven but it is really non-trivial if you're doing
interesting things with Maven to maintain support over long periods of
time for behaviors of older versions.
I'd seriously recommend you take the latest Maven release and call
that the Maven version. That is purely a recommendation. I'll help
whatever path is the consensus.
Thanks
Joe
On Fri, Jul 22, 2016 at 5:12 PM, Suneel Marthi <sm...@apache.org> wrote:
> Well most Apache projects r now at Maven >= 3.3.3.
>
> Spark is at 3.3.9.
>
> So why stick with 3.2.5 ?
>
> On Fri, Jul 22, 2016 at 5:10 PM, Tim Ellison <t....@gmail.com> wrote:
>
>> My understanding is that the change to Java 8 was because earlier versions
>> are now end of life, and Pirk's dependencies are moving to Java 8.
>>
>> What is the driver to move up to a later Maven version?
>>
>> I guess as a principle, specifying the lowest possible version of the
>> project's dependencies in the supported range allows for the broadest range
>> of target systems.
>>
>> On 22 July 2016 at 21:16, Suneel Marthi <sm...@apache.org> wrote:
>>
>> > Travis presently is set up with Maven 3.2.5. Consider going with a
>> minimum
>> > of 3.3.3 for Pirk, most other projects are at maven 3.3.9.
>> >
>> > I have the change for that as part of the PR for Pirk-10.
>> >
>>
Re: Minimum Maven version
Posted by Suneel Marthi <sm...@apache.org>.
Well most Apache projects r now at Maven >= 3.3.3.
Spark is at 3.3.9.
So why stick with 3.2.5 ?
On Fri, Jul 22, 2016 at 5:10 PM, Tim Ellison <t....@gmail.com> wrote:
> My understanding is that the change to Java 8 was because earlier versions
> are now end of life, and Pirk's dependencies are moving to Java 8.
>
> What is the driver to move up to a later Maven version?
>
> I guess as a principle, specifying the lowest possible version of the
> project's dependencies in the supported range allows for the broadest range
> of target systems.
>
> On 22 July 2016 at 21:16, Suneel Marthi <sm...@apache.org> wrote:
>
> > Travis presently is set up with Maven 3.2.5. Consider going with a
> minimum
> > of 3.3.3 for Pirk, most other projects are at maven 3.3.9.
> >
> > I have the change for that as part of the PR for Pirk-10.
> >
>
Re: Minimum Maven version
Posted by Tim Ellison <t....@gmail.com>.
My understanding is that the change to Java 8 was because earlier versions
are now end of life, and Pirk's dependencies are moving to Java 8.
What is the driver to move up to a later Maven version?
I guess as a principle, specifying the lowest possible version of the
project's dependencies in the supported range allows for the broadest range
of target systems.
On 22 July 2016 at 21:16, Suneel Marthi <sm...@apache.org> wrote:
> Travis presently is set up with Maven 3.2.5. Consider going with a minimum
> of 3.3.3 for Pirk, most other projects are at maven 3.3.9.
>
> I have the change for that as part of the PR for Pirk-10.
>