You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Claude Warren (Jira)" <ji...@apache.org> on 2024/06/27 07:34:00 UTC
[jira] [Commented] (RAT-390) Migrate exclusion calculations from plugin to core and add inclusion
[ https://issues.apache.org/jira/browse/RAT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860370#comment-17860370 ]
Claude Warren commented on RAT-390:
-----------------------------------
The plugin include functionality does not support regex but core does.
plugin has the concepts of exclude files for SCM/IDE types. specificially: maven, eclipse, and idea.
perhaps options like --input-ignore-maven, –input-ignore-eclipse, --input-ignore-idea, --input-ignore-regex, --input-ignore-git that take optional file name arguments. If specified without the file name they enable the default excludes for those types. With the file name they specify a file/directory of that format.
Also, the plugin filters files before they come into the input stream. The core filters after.
Since there are now two major input stream types (directory and archive) the filter needs to be able to be applied in both cases. We should review where to place the include/exclude filters.
The current plugin filter implementation seems to perform a complete scan of the input finding the files that should be included and then feeds them into the processing stream. This will involve a high overhead and storage requirement for large systems. We should explore if this can be converted to a streaming process.
Actually the entire filter may be possible as a Predicate<File> implementation.
> Migrate exclusion calculations from plugin to core and add inclusion
> --------------------------------------------------------------------
>
> Key: RAT-390
> URL: https://issues.apache.org/jira/browse/RAT-390
> Project: Apache Rat
> Issue Type: Sub-task
> Components: Client - cli, Client - maven, core engine
> Affects Versions: 0.16.1
> Reporter: Claude Warren
> Priority: Major
>
> the exclusion calculations in the Maven plugin are more comprehensive and better functioning than the ones in core. This ticket is to move the plugin exclusion calculations into the core package.
> In addition the Maven plugin also supports inclusion (specification of which files to execute against) this functionality should be moved to core when the exclusion is also moved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)