[GitHub] [calcite] danny0405 commented on a change in pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner
URL: https://github.com/apache/calcite/pull/1794#discussion_r378620001
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
 ##########
 @@ -160,6 +160,11 @@ protected void onMatch() {
         return;
       }
 
+      if (isRuleExcluded()) {
+        LOGGER.debug("Rule [{}] not fired due to exclusion hint", getRule());
 
 Review comment:
   It's hard to do that, because the operands can be matched from children to parent (ASENDING), for current implementation, i only want to match the root operand of the final match.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services