[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

[rhtyd <gi...@git.apache.org>]

Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1768#discussion_r103388263
  
    --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ---
    @@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion, CloudStackVersion currentVer
                     }
     
                     upgrade.performDataMigration(conn);
    -                boolean upgradeVersion = true;
    -
    -                if (upgrade.getUpgradedVersion().equals("2.1.8")) {
    --- End diff --
    
    I'm not sure about the implications, but since 2.x is a very old version -- we need to put in our release notes that we won't support upgrades from very old 2.x releases. We can in that case even remove all 2.x upgrade paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---