[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4206: [TE] frontend - harleyjj/create-alert - break yaml editor into two co…

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4206: [TE] frontend - harleyjj/create-alert - break yaml editor into two co…
URL: https://github.com/apache/incubator-pinot/pull/4206#discussion_r284930205
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/route.js
 ##########
 @@ -19,18 +19,22 @@ import { get } from '@ember/object';
 let onboardStartTime = {};
 
 export default Route.extend({
+  anomaliesApiService: service('services/api/anomalies'),
   session: service(),
 
   /**
    * Model hook for the create alert route.
    * @method model
    * @return {Object}
    */
-  model(params, transition) {
+  async model(params, transition) {
 
 Review comment:
   Nice refactor to use the async/await key words!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org