You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/01/30 01:22:17 UTC
[jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with OSGi)
(#273)
Artifact ID has also changed: bcprov-jdk16 -> bcprov-ext-jdk15on
1.6.x backport of https://github.com/jclouds/jclouds/pull/271
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds upgrade-bouncy-1.6.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/273
-- Commit Summary --
* Upgrading Bouncy Castle to 1.49 (1.50 has issues with OSGi)
-- File Changes --
M drivers/bouncycastle/pom.xml (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/273.patch
https://github.com/jclouds/jclouds/pull/273.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
Let's try these one more time with Maven 3.0.5 (rather than 3.0.3)...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33651482
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> So seems like upgrading sshj is the way to go. Thanks!
Thanks for testing, @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33978582
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrea Turli <no...@github.com>.
@demobox here is the gist you asked https://gist.github.com/andreaturli/b4c8d09a1e6fc1810852
Not sure how we can unit test this use case, though
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33931455
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
@andreaturli How are you getting the error? I just ran `mvn clean test` on master (as at 5e2052b2b) without problems. Also ran `mvn clean test` against 1.7.x (as at e69bea71b) without problems.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33807212
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1015](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1015/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33650495
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> It's happening with a LiveTest
Ah, OK. Could you put the stacktrace in a Gist or Pastie? Guess we're missing a unit test somewhere, then ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33808318
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> as for example jclouds-labs-google is now complaining because
Thanks for the heads-up, @andreaturli...sorry for not spotting that. Let's see what is going wrong here and how we can set up some CI builds to prevent this in future.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33805281
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #546 FAILURE
"No space left on device", eh? Let's try again...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33648492
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
Ah...I think this might be due to the fact that the SSHJ version (0.8.1) is on an [older version of Bouncycastle](https://github.com/shikhar/sshj/blob/v0.8.1/pom.xml#L209). I'll submit a PR to try to update to the latest version.
In the meantime, could you try a local build in which you explicitly exclude sshj from the jclouds-sshj driver and add in
<dependency>
<groupId>net.schmizz</groupId>
<artifactId>sshj</artifactId>
<version>0.9.0</version>
</dependency>
as a dep. You should be able to _remove_ the explicit Bouncycastle dep you added.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33970133
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrea Turli <no...@github.com>.
@demobox Not an expert but this seems ok for jclouds-labs-google:
```
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<version>1.49</version>
<exclusions>
<exclusion>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
</exclusion>
</exclusions>
</dependency>
```
Hope this helps
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33805542
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1014](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1014/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33648153
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1018 UNSTABLE
Ah, better. One of our usual [spurious test failures](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1018/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33653542
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #546](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/546/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33648232
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrea Turli <no...@github.com>.
@demobox It's happening with a LiveTest
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33807371
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #549](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/549/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33653257
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c56d7ad8cde78f43c813105860b7f1f3445a620a)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33653751
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #547](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/547/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33650490
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrea Turli <no...@github.com>.
@demobox I can confirm you that by excluding sshj from jclouds-sshj driver and adding what you susggested above things are ok (obviously removing my bouncycastle extra dep as well)
So seems like upgrading sshj is the way to go. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33976754
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrea Turli <no...@github.com>.
@demobox, is it possible that we need to add also
```
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<version>1.49</version>
</dependency>
```
as for example jclouds-labs-google is now complaining because
```java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: org/bouncycastle/openssl/PasswordFinder```
?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33787776
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1015 FAILURE
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:18.666s
[INFO] Finished at: Wed Jan 29 20:01:57 EST 2014
...
[JENKINS] Archiving /scratch/jenkins/workspace/jclouds-java-7-pull-requests/providers/aws-ec2/target/aws-ec2-1.6.4-SNAPSHOT-tests.jar to org.apache.jclouds.provider/aws-ec2/1.6.4-SNAPSHOT/aws-ec2-1.6.4-SNAPSHOT-tests.jar
[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.NullPointerException
```
Maven barf! Tests look good, though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33651414
Re: [jclouds] Upgrading Bouncy Castle to 1.49 (1.50 has issues with
OSGi) (#273)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1018](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1018/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33653213