You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/03/17 02:05:56 UTC

[GitHub] zeppelin pull request #2147: [HOTFIX] Restart button raises exception in int...

GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2147

    [HOTFIX] Restart button raises exception in interpreter side

    ### What is this PR for?
    This PR is the following one of #2140. It prevent from raising exception in interpreter side while closing interpreter.
    
    ### What type of PR is it?
    [Hot Fix]
    
    ### Todos
    * [x] - Remove open() while close()
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    N/A
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin hotfix/restart-raise-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2147
    
----
commit 93b4c1838f6cbb7b808859fe7a4fd4f072a41bc7
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-03-17T02:00:52Z

    Avoided opening interpreter while closing and calling close() in server side

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @zjffdu I made a new PR(#2149) for fixing what you mention. Can you check that PR and test it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2147: [HOTFIX] Restart button raises exception in int...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2147


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @zjffdu I've tested it with PythonInterpreter and reproduced it didn't work properly. I'll fix them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @zjffdu Thanks, I'll test it with that mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @jongyoul I try it in isolated mode per user, restart button seems still doesn't work. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @zjffdu Can you tell me which interpreter you use? In case of Spark, I found error occurs but it's kind of Spark issue because two separate "metastore_db" located in a same place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2147: [HOTFIX] Restart button raises exception in interprete...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2147
  
    @AhyoungRyu @Leemoonsoo tested it. Will merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---