You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/27 16:18:30 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #5697: [Fix-5701]When deleting a user, the accessToken associated with the user should also be deleted

ruanwenjun commented on a change in pull request #5697:
URL: https://github.com/apache/dolphinscheduler/pull/5697#discussion_r659344509



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java
##########
@@ -514,6 +518,8 @@ public int getUserIdByName(String name) {
             }
         }
 
+        accessTokenMapper.deleteAccessTokenByUserId(id);

Review comment:
       We may need to add transaction here, this service method involves 2 DML operations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org