[jira] [Commented] (MESOS-9141) Consider adding restrictions to disk profile names.

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735779#comment-16735779 ] 

Benjamin Bannier commented on MESOS-9141:
-----------------------------------------

Currently, the storage local resource provider (SLRP) just requests profiles from the disk profile adaptor, and applies them pretty mechanically to resources. Profile names are never injected in Mesos itself, but only in custom modules (the default module implementation never returns any profiles, the {{UriDiskProfileAdapator}} reads from an URI). Since SLRP also currently also never e.g., construct filesystem paths from profile names, I wonder why we would even want to restrict profile names at all. It seems this would be a concern of entity managing profile lifetime, i.e., not a Mesos concern.

[~chhsia0], shall we close this issue as {{WONT_FIX}}?

> Consider adding restrictions to disk profile names.
> ---------------------------------------------------
>
>                 Key: MESOS-9141
>                 URL: https://issues.apache.org/jira/browse/MESOS-9141
>             Project: Mesos
>          Issue Type: Improvement
>          Components: storage
>            Reporter: Chun-Hung Hsiao
>            Priority: Critical
>              Labels: mesosphere, storage
>
> We should add some restrictions to profile names. We could consider adding the following rules:
> 1. A profile name must not be empty.
> 2. A profile name must have at most 128 characters.
> 3. A profile name must consist of alphanumeric characters ({{[a-zA-Z0-9]}}), dashes ({{-}}), underscores({{_}}), or dots({{.}}). We might want to consider slashes({{/}}) or percent-signs ({{%}}) as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)