You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2016/05/09 23:40:32 UTC

[GitHub] kafka pull request: MINOR: Use `Record` instead of `ByteBufferMess...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1357

    MINOR: Use `Record` instead of `ByteBufferMessageSet` in `ProduceRequestTest`

    We want to phase out `ByteBufferMessageSet` eventually, so new code should favour `Record` where possible.
    
    Also use a fixed timestamp in `testCorruptLz4ProduceRequest` to ensure that
    the checksum is always the same.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka produce-request-test-improvement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1357
    
----
commit fb91b68c6173c18df9592e9735245c46c191cccd
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-05-09T23:37:28Z

    MINOR: Use `Record` instead of `ByteBufferMessageSet` in `ProduceRequestTest`
    
    Also use a fixed timestamp in `testCorruptLz4ProduceRequest` to ensure that
    the checksum is always the same.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: MINOR: Use `Record` instead of `ByteBufferMess...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---