[jira] [Comment Edited] (HBASE-12631) Backport HBASE-12576 (Add metrics for rolling the HLog if there are too few DN's in the write pipeline) to 0.98

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241726#comment-14241726 ] 

Andrew Purtell edited comment on HBASE-12631 at 12/10/14 9:07 PM:
------------------------------------------------------------------

bq. In 0.98 MetricsWAL isn't a WALActionsListener, so it isn't on the list that is notified about roll requests.

Ugh, well that's a big problem I didn't notice. Let me fix it. Thanks for looking this over.

bq.I 'm not sure how much we should care about the test gap to cover this.

There's a new test TestMetricsWAL, but unfortunately it's a small mock. I will look for a place where we can check log rolling metrics with a minicluster.  TestLogRolling didn't catch this because it registers its own listener.


was (Author: apurtell):
bq. In 0.98 MetricsWAL isn't a WALActionsListener, so it isn't on the list that is notified about roll requests.

Ugh, well that's a big problem I didn't notice. Let me fix it. Thanks for looking this over.

bq.I 'm not sure how much we should care about the test gap to cover this.

There's a new test TestMetricsWAL, but unfortunately it's a small mock. I will look for a place where we can check log rolling metrics with a minicluster. 

> Backport HBASE-12576 (Add metrics for rolling the HLog if there are too few DN's in the write pipeline) to 0.98
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12631
>                 URL: https://issues.apache.org/jira/browse/HBASE-12631
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.9
>
>         Attachments: HBASE-12631-0.98.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)