You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by udim <gi...@git.apache.org> on 2017/10/26 02:05:12 UTC

[GitHub] beam pull request #4040: [BEAM-1872] Add IdentityWindowFn for use in Reshuff...

GitHub user udim opened a pull request:

    https://github.com/apache/beam/pull/4040

    [BEAM-1872] Add IdentityWindowFn for use in Reshuffle

    BEAM-1872 IdentityWindowFn is intended for internal use in a future
    implementation of Reshuffle.
    
    Add and pass current window to WindowFn.AssignContext, for
    IdentityWindowFn implementation.
    
    Add WindowedValueMatcher in testing/util.py, for use in IdentityWindowFn
    unit tests.
    
    ----
    
    Hi @robertwb. Can you please take a look?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/udim/beam reshuffle_py

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4040
    
----
commit cb5bd6dbba492221e74889c70a503c2544a828c5
Author: Udi Meiri <eh...@google.com>
Date:   2017-10-25T22:45:39Z

    Add IdentityWindowFn.
    
    BEAM-1872 IdentityWindowFn is intended for internal use in a future
    implementation of Reshuffle.
    
    Add and pass current window to WindowFn.AssignContext, for
    IdentityWindowFn implementation.
    
    Add WindowedValueMatcher in testing/util.py, for use in IdentityWindowFn
    unit tests.

----


---