You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jamshid Afshar <ja...@caringo.com> on 2012/08/08 20:24:32 UTC

Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs
-----

  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


RE: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Edison Su <Ed...@citrix.com>.

> -----Original Message-----
> From: Jamshid Afshar [mailto:noreply@reviews.apache.org] On Behalf Of
> Jamshid Afshar
> Sent: Wednesday, August 08, 2012 12:29 PM
> To: cloudstack; David Nalley; Jamshid Afshar
> Subject: Re: Review Request: Add initial support for Caringo's CAStor
> object storage as the S3 backend.
> 
> 
> 
> > On Aug. 8, 2012, 6:36 p.m., David Nalley wrote:
> > > First, thanks for the patch.
> > > I haven't looked deeply in this, but noticed the license header in
> one of the files needs some work, see the below for more information:
> > > http://www.apache.org/legal/src-headers.html
> > > If you have questions, please don't hesitate to ask.
> > >
> > > --David
> 
> Okay I removed the Copyright on the new .java but now "git format-patch
> -s master" created 2 patch files. Should I try to revert the commit in
> git and resubmit a single patch, or can I add these two patch files. I

Better to squash two commits into one using: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

> tried "Update diff" but it only allows a single patch file and a
> "Parent".
> 
> 
> - Jamshid
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/#review10028
> -----------------------------------------------------------
> 
> 
> On Aug. 8, 2012, 6:24 p.m., Jamshid Afshar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6473/
> > -----------------------------------------------------------
> >
> > (Updated Aug. 8, 2012, 6:24 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Description
> > -------
> >
> > Below is the commit message. This is my first patch, let me know if I
> did anything wrong or if e.g. using "storage.root" is not how
> configuring a new storage backend should be done.
> >
> > Add initial support for Caringo's CAStor object storage as the S3
> backend.
> >
> > Similar to the s3-hdfs example. Now storage.root can specify "castor"
> > followed by a list of IP addresses for the nodes in the CAStor
> > cluster. S3 operations will then create and read buckets and objects
> > in CAStor instead of a file system.
> >
> >
> > Diffs
> > -----
> >
> >   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-
> CREATION
> >   awsapi/src/com/cloud/bridge/model/SHost.java 874b095
> >
> awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java
> 7a36a4b
> >   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4
> >   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION
> >   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/6473/diff/
> >
> >
> > Testing
> > -------
> >
> > Tested a boto script I believe we got from Chiradeep
> (localhost_test.py) that creates buckets and streams, does a range read
> and delete. I will continue to do more testing
> (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+Clou
> dStack+S3+Implementation).
> >
> >
> > Thanks,
> >
> > Jamshid Afshar
> >
> >


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 8, 2012, 6:36 p.m., David Nalley wrote:
> > First, thanks for the patch. 
> > I haven't looked deeply in this, but noticed the license header in one of the files needs some work, see the below for more information: 
> > http://www.apache.org/legal/src-headers.html 
> > If you have questions, please don't hesitate to ask. 
> > 
> > --David

Okay I removed the Copyright on the new .java but now "git format-patch -s master" created 2 patch files. Should I try to revert the commit in git and resubmit a single patch, or can I add these two patch files. I tried "Update diff" but it only allows a single patch file and a "Parent".


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10028
-----------------------------------------------------------


On Aug. 8, 2012, 6:24 p.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 6:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10028
-----------------------------------------------------------


First, thanks for the patch. 
I haven't looked deeply in this, but noticed the license header in one of the files needs some work, see the below for more information: 
http://www.apache.org/legal/src-headers.html 
If you have questions, please don't hesitate to ask. 

--David

- David Nalley


On Aug. 8, 2012, 6:24 p.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 6:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Eric Dey <er...@caringo.com>.

> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote:
> > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar?  I presume CAStorSDK is one that you own -- what about the other one?  The license on dependent libraries affects whether we can build the code as part of the default build or not.  If it is an open-source license that is compatible with the Apache license then things are very easy, but otherwise things get more complicated.
> > 
> > As general guidance:
> > 
> > The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your object store, which is obviously a big win.
> > 
> > The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to CAStor customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.
> > 
> > 
> > I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is today, with the deadline for sorting out all licensing issues being next week.  For your patch to get in, we'd have to get these license issues resolved very soon, and make an exception to the feature freeze.  If there is going to be any delay figuring out the licensing on these jars, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.
> > 
> > Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.
> >

Ewan, I'll answer for Jam in his absence. The JmDNS package is an Apache 2.0 license while the Caringo CAStorSDK package is a BSD license.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10157
-----------------------------------------------------------


On Aug. 9, 2012, 2:24 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 2:24 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Ewan Mellor <ew...@citrix.com>.

> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote:
> > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar?  I presume CAStorSDK is one that you own -- what about the other one?  The license on dependent libraries affects whether we can build the code as part of the default build or not.  If it is an open-source license that is compatible with the Apache license then things are very easy, but otherwise things get more complicated.
> > 
> > As general guidance:
> > 
> > The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your object store, which is obviously a big win.
> > 
> > The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to CAStor customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.
> > 
> > 
> > I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is today, with the deadline for sorting out all licensing issues being next week.  For your patch to get in, we'd have to get these license issues resolved very soon, and make an exception to the feature freeze.  If there is going to be any delay figuring out the licensing on these jars, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.
> > 
> > Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.
> >
> 
> Eric Dey wrote:
>     Ewan, I'll answer for Jam in his absence. The JmDNS package is an Apache 2.0 license while the Caringo CAStorSDK package is a BSD license.

OK, that's great, thanks.  Please give download URLs for those.  We want our build system to be able to download them from the official upstream servers, and we want to document where to get them if users need to upgrade.  Thanks.


- Ewan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10157
-----------------------------------------------------------


On Aug. 9, 2012, 2:24 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 2:24 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote:
> > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar?  I presume CAStorSDK is one that you own -- what about the other one?  The license on dependent libraries affects whether we can build the code as part of the default build or not.  If it is an open-source license that is compatible with the Apache license then things are very easy, but otherwise things get more complicated.
> > 
> > As general guidance:
> > 
> > The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your object store, which is obviously a big win.
> > 
> > The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to CAStor customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.
> > 
> > 
> > I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is today, with the deadline for sorting out all licensing issues being next week.  For your patch to get in, we'd have to get these license issues resolved very soon, and make an exception to the feature freeze.  If there is going to be any delay figuring out the licensing on these jars, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.
> > 
> > Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.
> >
> 
> Eric Dey wrote:
>     Ewan, I'll answer for Jam in his absence. The JmDNS package is an Apache 2.0 license while the Caringo CAStorSDK package is a BSD license.
> 
> Ewan Mellor wrote:
>     OK, that's great, thanks.  Please give download URLs for those.  We want our build system to be able to download them from the official upstream servers, and we want to document where to get them if users need to upgrade.  Thanks.
>

Sure, Ewan, we really want this feature in the CloudStack 4.0 release.

Here is the jmdns library's license: http://jmdns.sourceforge.net/license.html

I'll attach the license for our SDK jar and find out about a download url.

Btw Edison, the 2 binary files are in the attached patch file, not sure why the ui doen't let you download them individually.


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10157
-----------------------------------------------------------


On Aug. 9, 2012, 2:24 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 2:24 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Ewan Mellor <ew...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10157
-----------------------------------------------------------


Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar?  I presume CAStorSDK is one that you own -- what about the other one?  The license on dependent libraries affects whether we can build the code as part of the default build or not.  If it is an open-source license that is compatible with the Apache license then things are very easy, but otherwise things get more complicated.

As general guidance:

The easiest thing to do is to license your code under the Apache license, or a compatible one such as BSD.  This will mean that we can have the default CloudStack build include support for your object store, which is obviously a big win.

The Apache Foundation won't allow code that requires proprietary libraries in the default configuration, so if you can't do this, then the feature would have to be off by default.  This isn't the end of the world, but it means that users would have to recompile CloudStack from source to enable your software.  This would be the case if that jar is only available to CAStor customers or otherwise not freely distributable.  We're going to have to turn off NetApp support in the default build for this reason, to give you an example.


I don't know if you know this, but we're trying to get a CloudStack 4.0 release together in the next month.  The deadline for feature freeze is today, with the deadline for sorting out all licensing issues being next week.  For your patch to get in, we'd have to get these license issues resolved very soon, and make an exception to the feature freeze.  If there is going to be any delay figuring out the licensing on these jars, would it be a problem if this patch didn't get into CloudStack 4.0?  If that's OK, it would go immediately on the list for 4.1 instead.  That would give you time to sort out what you want to do here.

Please let me know what you're planning to do at this point, so that we can finalize the upcoming release.


- Ewan Mellor


On Aug. 9, 2012, 2:24 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 2:24 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10136
-----------------------------------------------------------


CAStorSDK.jar and jmdns-2.1.jar are missing, seems the patch send to RB can't contain binary files?

- edison su


On Aug. 9, 2012, 2:24 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 2:24 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 72
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line72>
> >
> >     This logic seems suspect: if the port is not specified or if only the port is specified.

It should be okay because it throws a ConfigurationException if it doesn't find any IP's. I verified error with storage.root set to "castor" or "castor 80".


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 193
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line193>
> >
> >     You might leave temporary files around here.

Thanks, corrected by putting this into the block containing the "finally" that deletes the temporary file.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 169
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line169>
> >
> >     you should probably set file.deleteOnExit()
> >     Also, "file" is a bad variable name. Even tempFile is a better name

I improved the name and made sure to delete the file in the "finally" block. I don't think I want deleteOnExit() because I don't want the (potentially large) files hanging around, and it causes (a small) memory usage.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 200
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line200>
> >
> >     cant really progress after this error?

Right, if close failed the file contents aren't reliable, so this now throws an exception.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 248
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line248>
> >
> >     UnsupportedOperation?

Yes.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java, line 1383
> > <https://reviews.apache.org/r/6473/diff/2/?file=135875#file135875line1383>
> >
> >     Why would there be an exception here? And if there is, why isn't the operation failing (the code continues)

No reason for exception, removed catch.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 92
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line92>
> >
> >     ConfigurationException?

Right, that's more appropriate.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 80
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line80>
> >
> >     This would be a ConfigurationException?

Right, that's more appropriate.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 73
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line73>
> >
> >     magic number? Make it a final

Made constants finals.


> On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote:
> > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 55
> > <https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line55>
> >
> >     Can you make sure your code follows these conventions:
> >     https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions

Sorry it should now conform.


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10312
-----------------------------------------------------------


On Aug. 15, 2012, 2:29 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 8a3b0bf 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10312
-----------------------------------------------------------



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21834>

    Can you make sure your code follows these conventions:
    https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21838>

    This logic seems suspect: if the port is not specified or if only the port is specified.



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21836>

    magic number? Make it a final



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21839>

    This would be a ConfigurationException?



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21841>

    Magic numbers should be constants and documented



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21842>

    ConfigurationException?



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21845>

    you should probably set file.deleteOnExit()
    Also, "file" is a bad variable name. Even tempFile is a better name



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21843>

    You might leave temporary files around here.



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21844>

    cant really progress after this error?



awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
<https://reviews.apache.org/r/6473/#comment21847>

    UnsupportedOperation?



awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java
<https://reviews.apache.org/r/6473/#comment21850>

    Why would there be an exception here? And if there is, why isn't the operation failing (the code continues)


- Chiradeep Vittal


On Aug. 10, 2012, 11:47 p.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2012, 11:47 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote:
> > Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from?
> 
> David Nalley wrote:
>     Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to clean up the source repo. They need to be handled as dependencies (either with the ant target for deps in the deps-ctrl branch, or with gradle, or maven)
> 
> Jamshid Afshar wrote:
>     Sure, we can comply with whatever dependency system you need. For now the files are available here:
>     
>     http://vault.caringo.com/cloudstack/4.0/CAStorSDK-LICENSE.txt
>     http://vault.caringo.com/cloudstack/4.0/CAStorSDK.jar
>     http://vault.caringo.com/cloudstack/4.0/jmdns-2.1.jar
>

I'm trying to get CaringoSDK.jar onto maven central via https://issues.sonatype.org/browse/OSSRH-4219.


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10358
-----------------------------------------------------------


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote:
> > Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from?
> 
> David Nalley wrote:
>     Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to clean up the source repo. They need to be handled as dependencies (either with the ant target for deps in the deps-ctrl branch, or with gradle, or maven)

Sure, we can comply with whatever dependency system you need. For now the files are available here:

http://vault.caringo.com/cloudstack/4.0/CAStorSDK-LICENSE.txt
http://vault.caringo.com/cloudstack/4.0/CAStorSDK.jar
http://vault.caringo.com/cloudstack/4.0/jmdns-2.1.jar


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10358
-----------------------------------------------------------


On Aug. 15, 2012, 2:29 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 8a3b0bf 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote:
> > Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from?
> 
> David Nalley wrote:
>     Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to clean up the source repo. They need to be handled as dependencies (either with the ant target for deps in the deps-ctrl branch, or with gradle, or maven)
> 
> Jamshid Afshar wrote:
>     Sure, we can comply with whatever dependency system you need. For now the files are available here:
>     
>     http://vault.caringo.com/cloudstack/4.0/CAStorSDK-LICENSE.txt
>     http://vault.caringo.com/cloudstack/4.0/CAStorSDK.jar
>     http://vault.caringo.com/cloudstack/4.0/jmdns-2.1.jar
>
> 
> Jamshid Afshar wrote:
>     I'm trying to get CaringoSDK.jar onto maven central via https://issues.sonatype.org/browse/OSSRH-4219.

Okay our jar should be available within the hour.


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10358
-----------------------------------------------------------


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by David Nalley <da...@gnsa.us>.

> On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote:
> > Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from?

Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to clean up the source repo. They need to be handled as dependencies (either with the ant target for deps in the deps-ctrl branch, or with gradle, or maven) 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10358
-----------------------------------------------------------


On Aug. 15, 2012, 2:29 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 8a3b0bf 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10358
-----------------------------------------------------------


Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from?

- Chiradeep Vittal


On Aug. 15, 2012, 2:29 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 8a3b0bf 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chip Childers <ch...@sungard.com>.
On Thu, Sep 6, 2012 at 12:54 PM, Chiradeep Vittal
<Ch...@citrix.com> wrote:
> Sorry about that. I should have been more careful.

No worries!  It's fixed in master.

> On 9/6/12 8:37 AM, "Chip Childers" <ch...@sungard.com> wrote:
>
>>And actually, after looking at the commit, the licensing statement
>>actually belongs in the LICENSE file and not the NOTICE file.
>>
>>On Thu, Sep 6, 2012 at 11:34 AM, Chip Childers
>><ch...@sungard.com> wrote:
>>> Hey all,
>>>
>>> Can I ask a favor, which is to not edit the NOTICE and LICENSE files
>>>directly?
>>>
>>> I'm trying to keep things structured within the
>>> tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are
>>> generated from that structured data.
>>>
>>> I'll take a look at the change in the commit, and integrate it into
>>> the descriptor.xml file shortly.
>>>
>>> -chip
>>>
>>>
>>> On Thu, Sep 6, 2012 at 2:37 AM, Chiradeep Vittal <ch...@gmail.com>
>>>wrote:
>>>>
>>>> -----------------------------------------------------------
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviews.apache.org/r/6473/#review11086
>>>> -----------------------------------------------------------
>>>>
>>>> Ship it!
>>>>
>>>>
>>>> I committed this to master. I did not see JmDns in the pom.xml so I
>>>>removed it from the NOTICE
>>>>
>>>> - Chiradeep Vittal
>>>>
>>>>
>>>> On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote:
>>>>>
>>>>> -----------------------------------------------------------
>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>> https://reviews.apache.org/r/6473/
>>>>> -----------------------------------------------------------
>>>>>
>>>>> (Updated Sept. 6, 2012, 12:07 a.m.)
>>>>>
>>>>>
>>>>> Review request for cloudstack.
>>>>>
>>>>>
>>>>> Description
>>>>> -------
>>>>>
>>>>> Below is the commit message. This is my first patch, let me know if I
>>>>>did anything wrong or if e.g. using "storage.root" is not how
>>>>>configuring a new storage backend should be done.
>>>>>
>>>>> Add initial support for Caringo's CAStor object storage as the S3
>>>>>backend.
>>>>>
>>>>> Similar to the s3-hdfs example. Now storage.root can specify "castor"
>>>>> followed by a list of IP addresses for the nodes in the CAStor
>>>>> cluster. S3 operations will then create and read buckets and objects
>>>>> in CAStor instead of a file system.
>>>>>
>>>>>
>>>>> Diffs
>>>>> -----
>>>>>
>>>>>   NOTICE 9c124ab
>>>>>   awsapi/pom.xml 2909376
>>>>>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
>>>>>PRE-CREATION
>>>>>   awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e
>>>>>
>>>>>awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java
>>>>>2f1791e
>>>>>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13
>>>>>
>>>>> Diff: https://reviews.apache.org/r/6473/diff/
>>>>>
>>>>>
>>>>> Testing
>>>>> -------
>>>>>
>>>>> Tested a boto script I believe we got from Chiradeep
>>>>>(localhost_test.py) that creates buckets and streams, does a range
>>>>>read and delete. I will continue to do more testing
>>>>>(http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+Clou
>>>>>dStack+S3+Implementation).
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jamshid Afshar
>>>>>
>>>>>
>>>>
>
>

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <Ch...@citrix.com>.
Sorry about that. I should have been more careful.

On 9/6/12 8:37 AM, "Chip Childers" <ch...@sungard.com> wrote:

>And actually, after looking at the commit, the licensing statement
>actually belongs in the LICENSE file and not the NOTICE file.
>
>On Thu, Sep 6, 2012 at 11:34 AM, Chip Childers
><ch...@sungard.com> wrote:
>> Hey all,
>>
>> Can I ask a favor, which is to not edit the NOTICE and LICENSE files
>>directly?
>>
>> I'm trying to keep things structured within the
>> tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are
>> generated from that structured data.
>>
>> I'll take a look at the change in the commit, and integrate it into
>> the descriptor.xml file shortly.
>>
>> -chip
>>
>>
>> On Thu, Sep 6, 2012 at 2:37 AM, Chiradeep Vittal <ch...@gmail.com>
>>wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/6473/#review11086
>>> -----------------------------------------------------------
>>>
>>> Ship it!
>>>
>>>
>>> I committed this to master. I did not see JmDns in the pom.xml so I
>>>removed it from the NOTICE
>>>
>>> - Chiradeep Vittal
>>>
>>>
>>> On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote:
>>>>
>>>> -----------------------------------------------------------
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviews.apache.org/r/6473/
>>>> -----------------------------------------------------------
>>>>
>>>> (Updated Sept. 6, 2012, 12:07 a.m.)
>>>>
>>>>
>>>> Review request for cloudstack.
>>>>
>>>>
>>>> Description
>>>> -------
>>>>
>>>> Below is the commit message. This is my first patch, let me know if I
>>>>did anything wrong or if e.g. using "storage.root" is not how
>>>>configuring a new storage backend should be done.
>>>>
>>>> Add initial support for Caringo's CAStor object storage as the S3
>>>>backend.
>>>>
>>>> Similar to the s3-hdfs example. Now storage.root can specify "castor"
>>>> followed by a list of IP addresses for the nodes in the CAStor
>>>> cluster. S3 operations will then create and read buckets and objects
>>>> in CAStor instead of a file system.
>>>>
>>>>
>>>> Diffs
>>>> -----
>>>>
>>>>   NOTICE 9c124ab
>>>>   awsapi/pom.xml 2909376
>>>>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java
>>>>PRE-CREATION
>>>>   awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e
>>>>   
>>>>awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java
>>>>2f1791e
>>>>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13
>>>>
>>>> Diff: https://reviews.apache.org/r/6473/diff/
>>>>
>>>>
>>>> Testing
>>>> -------
>>>>
>>>> Tested a boto script I believe we got from Chiradeep
>>>>(localhost_test.py) that creates buckets and streams, does a range
>>>>read and delete. I will continue to do more testing
>>>>(http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+Clou
>>>>dStack+S3+Implementation).
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Jamshid Afshar
>>>>
>>>>
>>>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chip Childers <ch...@sungard.com>.
And actually, after looking at the commit, the licensing statement
actually belongs in the LICENSE file and not the NOTICE file.

On Thu, Sep 6, 2012 at 11:34 AM, Chip Childers
<ch...@sungard.com> wrote:
> Hey all,
>
> Can I ask a favor, which is to not edit the NOTICE and LICENSE files directly?
>
> I'm trying to keep things structured within the
> tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are
> generated from that structured data.
>
> I'll take a look at the change in the commit, and integrate it into
> the descriptor.xml file shortly.
>
> -chip
>
>
> On Thu, Sep 6, 2012 at 2:37 AM, Chiradeep Vittal <ch...@gmail.com> wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6473/#review11086
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> I committed this to master. I did not see JmDns in the pom.xml so I removed it from the NOTICE
>>
>> - Chiradeep Vittal
>>
>>
>> On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/6473/
>>> -----------------------------------------------------------
>>>
>>> (Updated Sept. 6, 2012, 12:07 a.m.)
>>>
>>>
>>> Review request for cloudstack.
>>>
>>>
>>> Description
>>> -------
>>>
>>> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
>>>
>>> Add initial support for Caringo's CAStor object storage as the S3 backend.
>>>
>>> Similar to the s3-hdfs example. Now storage.root can specify "castor"
>>> followed by a list of IP addresses for the nodes in the CAStor
>>> cluster. S3 operations will then create and read buckets and objects
>>> in CAStor instead of a file system.
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>   NOTICE 9c124ab
>>>   awsapi/pom.xml 2909376
>>>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION
>>>   awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e
>>>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 2f1791e
>>>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13
>>>
>>> Diff: https://reviews.apache.org/r/6473/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
>>>
>>>
>>> Thanks,
>>>
>>> Jamshid Afshar
>>>
>>>
>>

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chip Childers <ch...@sungard.com>.
Hey all,

Can I ask a favor, which is to not edit the NOTICE and LICENSE files directly?

I'm trying to keep things structured within the
tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are
generated from that structured data.

I'll take a look at the change in the commit, and integrate it into
the descriptor.xml file shortly.

-chip


On Thu, Sep 6, 2012 at 2:37 AM, Chiradeep Vittal <ch...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/#review11086
> -----------------------------------------------------------
>
> Ship it!
>
>
> I committed this to master. I did not see JmDns in the pom.xml so I removed it from the NOTICE
>
> - Chiradeep Vittal
>
>
> On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/6473/
>> -----------------------------------------------------------
>>
>> (Updated Sept. 6, 2012, 12:07 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description
>> -------
>>
>> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
>>
>> Add initial support for Caringo's CAStor object storage as the S3 backend.
>>
>> Similar to the s3-hdfs example. Now storage.root can specify "castor"
>> followed by a list of IP addresses for the nodes in the CAStor
>> cluster. S3 operations will then create and read buckets and objects
>> in CAStor instead of a file system.
>>
>>
>> Diffs
>> -----
>>
>>   NOTICE 9c124ab
>>   awsapi/pom.xml 2909376
>>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION
>>   awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e
>>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 2f1791e
>>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13
>>
>> Diff: https://reviews.apache.org/r/6473/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
>>
>>
>> Thanks,
>>
>> Jamshid Afshar
>>
>>
>

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review11086
-----------------------------------------------------------

Ship it!


I committed this to master. I did not see JmDns in the pom.xml so I removed it from the NOTICE

- Chiradeep Vittal


On Sept. 6, 2012, 12:07 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 12:07 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/pom.xml 2909376 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 2f1791e 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Sept. 6, 2012, 12:07 a.m.)


Review request for cloudstack.


Changes
-------

Clean patch against current master (due to removal of Hibernate) and with awsapi/pom.xml update (CAStorSDK.jar now in maven central).


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs (updated)
-----

  NOTICE 9c124ab 
  awsapi/pom.xml 2909376 
  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 4ed5b7e 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 2f1791e 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java a117d13 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Sept. 4, 2012, 10:11 p.m., Chiradeep Vittal wrote:
> > Jamshid, could you re-submit patches against latest master? I am also looking for the build file (pom.xml) changes.

I believe adding this to pom.xml is all that is needed, though CAStorSDK doesn't seem to have sync'd to the central repository yet. I've asked in https://issues.sonatype.org/browse/OSSRH-4219 if they know why it's not available yet.

        <dependency>
            <groupId>com.caringo.client</groupId>
            <artifactId>CAStorSDK</artifactId>
            <version>1.3.1-CS40</version>
        </dependency>


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review11037
-----------------------------------------------------------


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review11037
-----------------------------------------------------------


Jamshid, could you re-submit patches against latest master? I am also looking for the build file (pom.xml) changes.

- Chiradeep Vittal


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.

> On Sept. 4, 2012, 10:26 p.m., Chiradeep Vittal wrote:
> > I think that since Rajesh removed the Hibernate dependency, the patch does not merge clean any more. Hence I am requesting a clean patch.

Okay, I'll try again...


- Jamshid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review11040
-----------------------------------------------------------


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review11040
-----------------------------------------------------------


I think that since Rajesh removed the Hibernate dependency, the patch does not merge clean any more. Hence I am requesting a clean patch.

- Chiradeep Vittal


On Aug. 23, 2012, 1:40 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 1:40 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 9c124ab 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


RE: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Sudha Ponnaganti <su...@citrix.com>.
Jamshid,

Hope your testing is going ok. Based on your experience, do you see any additional test suites that would help to get max coverage for s3 implementation. The tests you are running give decent coverage but I would like to enhance coverage if there is an immediate need. 

Thanks
/Sudha



-----Original Message-----
From: Jamshid Afshar [mailto:noreply@reviews.apache.org] On Behalf Of Jamshid Afshar
Sent: Wednesday, August 22, 2012 6:40 PM
To: David Nalley; Edison Su; Ewan Mellor; Jamshid Afshar; cloudstack; Chiradeep Vittal; Eric Dey
Subject: Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 1:40 a.m.)


Review request for cloudstack.


Changes
-------

Chiradeep, here are the diffs against current master. I also made some internal changes to S3CAStorBucketAdapter to support "domain" and "zeroconf" in configuration.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor cluster. S3 operations will then create and read buckets and objects in CAStor instead of a file system.


Diffs (updated)
-----

  NOTICE 9c124ab
  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION
  awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 1:40 a.m.)


Review request for cloudstack.


Changes
-------

Chiradeep, here are the diffs against current master. I also made some internal changes to S3CAStorBucketAdapter to support "domain" and "zeroconf" in configuration.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs (updated)
-----

  NOTICE 9c124ab 
  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 758cbbf 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java c8ca2bd 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/#review10349
-----------------------------------------------------------

Ship it!


Ship It!

- Chiradeep Vittal


On Aug. 15, 2012, 2:29 a.m., Jamshid Afshar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6473/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.
> 
> Add initial support for Caringo's CAStor object storage as the S3 backend.
> 
> Similar to the s3-hdfs example. Now storage.root can specify "castor"
> followed by a list of IP addresses for the nodes in the CAStor
> cluster. S3 operations will then create and read buckets and objects
> in CAStor instead of a file system.
> 
> 
> Diffs
> -----
> 
>   NOTICE 8a3b0bf 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
>   awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
>   awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
>   deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
>   deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
>   deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/6473/diff/
> 
> 
> Testing
> -------
> 
> Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).
> 
> 
> Thanks,
> 
> Jamshid Afshar
> 
>


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Aug. 15, 2012, 2:29 a.m.)


Review request for cloudstack.


Changes
-------

Corrections and reformatting based on Chiradeep's 2012-08-14 review.
NOTICES now mentions CAStorSDK and JmDNS and CAStorSDK-LICENSE.txt added.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs (updated)
-----

  NOTICE 8a3b0bf 
  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
  deps/awsapi-lib/CAStorSDK-LICENSE.txt PRE-CREATION 
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Aug. 10, 2012, 11:47 p.m.)


Review request for cloudstack.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs
-----

  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar


Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

Posted by Jamshid Afshar <ja...@caringo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6473/
-----------------------------------------------------------

(Updated Aug. 9, 2012, 2:24 a.m.)


Review request for cloudstack.


Changes
-------

I removed the Copyright on the new file and used "git rebase" to combine it into a single diff/patch.


Description
-------

Below is the commit message. This is my first patch, let me know if I did anything wrong or if e.g. using "storage.root" is not how configuring a new storage backend should be done.

Add initial support for Caringo's CAStor object storage as the S3 backend.

Similar to the s3-hdfs example. Now storage.root can specify "castor"
followed by a list of IP addresses for the nodes in the CAStor
cluster. S3 operations will then create and read buckets and objects
in CAStor instead of a file system.


Diffs (updated)
-----

  awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/model/SHost.java 874b095 
  awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 7a36a4b 
  awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 
  deps/awsapi-lib/CAStorSDK.jar PRE-CREATION 
  deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION 

Diff: https://reviews.apache.org/r/6473/diff/


Testing
-------

Tested a boto script I believe we got from Chiradeep (localhost_test.py) that creates buckets and streams, does a range read and delete. I will continue to do more testing (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+CloudStack+S3+Implementation).


Thanks,

Jamshid Afshar