You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/08 03:06:32 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7080: alarm config support i18n

wu-sheng commented on a change in pull request #7080:
URL: https://github.com/apache/skywalking/pull/7080#discussion_r647076466



##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -264,16 +268,16 @@ private void readFeishuConfig(Rules rules) {
     @SuppressWarnings("unchecked")
     private void readWeLinkConfig(Rules rules) {
         Map<String, Object> welinkConfig = (Map<String, Object>) yamlData.getOrDefault(
-            "welinkHooks",
-            Collections.EMPTY_MAP
+                "welinkHooks",

Review comment:
       Unexpected change, please revert and polish changes.

##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -45,6 +47,7 @@
     private WeLinkSettings welinks;
 
     public Rules() {
+        this.language = "cn";

Review comment:
       Why cn?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org