[jira] [Commented] (CASSANDRA-15076) Align record header of FQL and audit binary log

["Per Otterström (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834649#comment-16834649 ] 

Per Otterström commented on CASSANDRA-15076:
--------------------------------------------

I've created a patch based on the proposal above.

[Patch|https://github.com/eperott/cassandra/tree/15076-trunk]
[Unit tests|https://circleci.com/gh/eperott/cassandra/66#tests/containers/2]
[FQL Unit tests|https://circleci.com/gh/eperott/cassandra/67]

A local run of the dtests result in some flaky failures, but nothing that seem related to fql or audit. In particular, the {{auditlog_test.py}} and {{fqltool_test.py}} run without errors.


> Align record header of FQL and audit binary log
> -----------------------------------------------
>
>                 Key: CASSANDRA-15076
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15076
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Tools, Tool/fql
>            Reporter: Per Otterström
>            Assignee: Per Otterström
>            Priority: Normal
>             Fix For: 4.0
>
>
> The new full query logger and the audit logger support logging into binary Chronicle logs. Both create records with a small header to indicate what follows, but the two features have adopted different header formats. Let's align the record header format with this ticket.
>  * Both features should use the same header layout. This makes it possible to give more user friendly error messages in the {{fqltool}} and {{auditlogviewr}} commands.
>  * The record header should have a distinct {{type}} to indicate the type of record.
>  * The record header should have a {{version}} so that the record format can evolve.
> Current record header format of the FQL is:
> {noformat}
> version:0(int16)
> type:<type>(text)
> {noformat}
> where {{<type>}} can be either {{batch}} or {{single-query}}.
> Current record header format of the binary audit log is:
> {noformat}
> type:AuditLog(text)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org