You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Vyacheslav Daradur <da...@gmail.com> on 2018/04/03 16:28:29 UTC

Re: abbrevation rules plugin

Hi, Igniters!

I got into the task [1] in agreement with Dmitry.

I’ve prepared the PR [2] with following changes:
- added Apache 2.0 license to the header of each file
- replaced prefix ‘Grid’ by ‘Ignite’ in class names
- added README.md with a simple description
- changed version 2.6.3 -> 3.0.0 because the project has own GitHub
releases tab and completely new versioning isn't preferable IMO

Also, I’ve built new artifact and tested it, it works well.

Am I understood the task correct?
If not, please share your notes I will fix them shortly.

As far as I understand someone of GridGain employee should confirm the
plugin's code's donation. It’d be great to confirm that by corporate
email.


[1] https://issues.apache.org/jira/browse/IGNITE-5698
[2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1


On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com> wrote:
> Hi Dmitriy, Denis,
>
> Thank you for your effort to find out solution.
> It sound good for me, I have assigned IGNITE-5698 to myself.
>
> Best Regards,
> Dmitriy Pavlov
>
>
> чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
>
>> Dmitriy P.,
>>
>> Does it sound good to you? If yes, please make sure the plugin is
>> available via a public GitHub repo and refer to it from the doc.
>>
>> —
>> Denis
>>
>> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <ds...@apache.org>
>> wrote:
>> >
>> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org> wrote:
>> >
>> >> Ok, what if we make sure the plugin is available on GitHub (not Ignite)
>> >> and give a link to it on the documentation page? This seems to be the
>> >> easiest way to handle the topic.
>> >
>> >
>> > I think this will work.
>>
>>



-- 
Best Regards, Vyacheslav D.

Re: abbrevation rules plugin

Posted by Dmitry Pavlov <dp...@gmail.com>.
Anton, I also agree here.

Personal github repo is ok for very beginning of tool development, but
eventually apache repo is better.

вт, 3 апр. 2018 г. в 19:46, Anton Vinogradov <av...@apache.org>:

> Awesome!
>
> Dmitriy,
> please confirm donation and apply the patch.
>
> BTW, we can relocate plugin to apache repo like we did for release scripts
> [1].
>
> [1] https://github.com/apache/ignite-release
>
>
> 2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <da...@gmail.com>:
>
> > Hi, Igniters!
> >
> > I got into the task [1] in agreement with Dmitry.
> >
> > I’ve prepared the PR [2] with following changes:
> > - added Apache 2.0 license to the header of each file
> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > - added README.md with a simple description
> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> > releases tab and completely new versioning isn't preferable IMO
> >
> > Also, I’ve built new artifact and tested it, it works well.
> >
> > Am I understood the task correct?
> > If not, please share your notes I will fix them shortly.
> >
> > As far as I understand someone of GridGain employee should confirm the
> > plugin's code's donation. It’d be great to confirm that by corporate
> > email.
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> >
> >
> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> > > Hi Dmitriy, Denis,
> > >
> > > Thank you for your effort to find out solution.
> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > >
> > > Best Regards,
> > > Dmitriy Pavlov
> > >
> > >
> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> > >
> > >> Dmitriy P.,
> > >>
> > >> Does it sound good to you? If yes, please make sure the plugin is
> > >> available via a public GitHub repo and refer to it from the doc.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > >> wrote:
> > >> >
> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> > wrote:
> > >> >
> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
> > Ignite)
> > >> >> and give a link to it on the documentation page? This seems to be
> the
> > >> >> easiest way to handle the topic.
> > >> >
> > >> >
> > >> > I think this will work.
> > >>
> > >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >
>

Re: abbrevation rules plugin

Posted by Dmitry Pavlov <dp...@gmail.com>.
Thank you, Vyaceslav.

Excellent patch, I've applied PR to
https://github.com/dspavlov/ignite-abbrev-plugin

If we want code style will be learned by all contributors, this donation is
unavoidable.

Dmitriy S,

what do you think?

Lets keep current code base in my github and add build and link to build to
wiki page
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules .

Sincerely,
Dmitriy Pavlov

вт, 3 апр. 2018 г. в 19:46, Anton Vinogradov <av...@apache.org>:

> Awesome!
>
> Dmitriy,
> please confirm donation and apply the patch.
>
> BTW, we can relocate plugin to apache repo like we did for release scripts
> [1].
>
> [1] https://github.com/apache/ignite-release
>
>
> 2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <da...@gmail.com>:
>
> > Hi, Igniters!
> >
> > I got into the task [1] in agreement with Dmitry.
> >
> > I’ve prepared the PR [2] with following changes:
> > - added Apache 2.0 license to the header of each file
> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > - added README.md with a simple description
> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> > releases tab and completely new versioning isn't preferable IMO
> >
> > Also, I’ve built new artifact and tested it, it works well.
> >
> > Am I understood the task correct?
> > If not, please share your notes I will fix them shortly.
> >
> > As far as I understand someone of GridGain employee should confirm the
> > plugin's code's donation. It’d be great to confirm that by corporate
> > email.
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> >
> >
> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> > > Hi Dmitriy, Denis,
> > >
> > > Thank you for your effort to find out solution.
> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > >
> > > Best Regards,
> > > Dmitriy Pavlov
> > >
> > >
> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> > >
> > >> Dmitriy P.,
> > >>
> > >> Does it sound good to you? If yes, please make sure the plugin is
> > >> available via a public GitHub repo and refer to it from the doc.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > >> wrote:
> > >> >
> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> > wrote:
> > >> >
> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
> > Ignite)
> > >> >> and give a link to it on the documentation page? This seems to be
> the
> > >> >> easiest way to handle the topic.
> > >> >
> > >> >
> > >> > I think this will work.
> > >>
> > >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >
>

Re: abbrevation rules plugin

Posted by Anton Vinogradov <av...@apache.org>.
Awesome!

Dmitriy,
please confirm donation and apply the patch.

BTW, we can relocate plugin to apache repo like we did for release scripts
[1].

[1] https://github.com/apache/ignite-release


2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <da...@gmail.com>:

> Hi, Igniters!
>
> I got into the task [1] in agreement with Dmitry.
>
> I’ve prepared the PR [2] with following changes:
> - added Apache 2.0 license to the header of each file
> - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> - added README.md with a simple description
> - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> releases tab and completely new versioning isn't preferable IMO
>
> Also, I’ve built new artifact and tested it, it works well.
>
> Am I understood the task correct?
> If not, please share your notes I will fix them shortly.
>
> As far as I understand someone of GridGain employee should confirm the
> plugin's code's donation. It’d be great to confirm that by corporate
> email.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-5698
> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
>
>
> On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
> > Hi Dmitriy, Denis,
> >
> > Thank you for your effort to find out solution.
> > It sound good for me, I have assigned IGNITE-5698 to myself.
> >
> > Best Regards,
> > Dmitriy Pavlov
> >
> >
> > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> >
> >> Dmitriy P.,
> >>
> >> Does it sound good to you? If yes, please make sure the plugin is
> >> available via a public GitHub repo and refer to it from the doc.
> >>
> >> —
> >> Denis
> >>
> >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <ds...@apache.org>
> >> wrote:
> >> >
> >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> wrote:
> >> >
> >> >> Ok, what if we make sure the plugin is available on GitHub (not
> Ignite)
> >> >> and give a link to it on the documentation page? This seems to be the
> >> >> easiest way to handle the topic.
> >> >
> >> >
> >> > I think this will work.
> >>
> >>
>
>
>
> --
> Best Regards, Vyacheslav D.
>

Re: abbrevation rules plugin

Posted by Vyacheslav Daradur <da...@gmail.com>.
I'd like to thank GridGain's engineers for the plugin's donation.

I believe that the plugin will help Ignite's developers prepare PR
with the higher quality of code style what will reduce reviewer's time
for PR checking.

Dmitry thank you for the task's pushing!


On Mon, May 14, 2018 at 7:27 PM, Dmitry Pavlov <dp...@gmail.com> wrote:
> Anton, thank you for pointing to this.
>
> I've updated wiki page with build and references:
> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
>
> and attached jar file
> https://cwiki.apache.org/confluence/pages/viewpageattachments.action?pageId=57901460
>
> Thanks to Vyacheslav plugin is now published.
>
> Sincerely,
> Dmitriy Pavlov
>
>
> пн, 14 мая 2018 г. в 19:14, Anton Vinogradov <av...@apache.org>:
>>
>> Jar already attached to issue :)
>>
>> see https://issues.apache.org/jira/browse/IGNITE-5698
>>
>> пн, 14 мая 2018 г. в 19:05, Dmitry Pavlov <dp...@gmail.com>:
>>
>> > Hi Folks,
>> >
>> > I suggest to keep it in https://github.com/dspavlov/ignite-abbrev-plugin
>> > for
>> > the beginning. Late we can consider Apache repo.
>> >
>> > But for wiki I need some distribution to attach first.
>> >
>> > Vyacheslav, could you remind me if we already have one?
>> >
>> > пн, 14 мая 2018 г. в 19:00, Anton Vinogradov <av...@apache.org>:
>> >
>> > > Awesome!
>> > >
>> > > Let's mention it officially on wiki.
>> > > Do we need special apache repo for this plugin? As for me, public
>> > > github
>> > > repo is enough.
>> > >
>> > > пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dp...@gridgain.com>:
>> > >
>> > > > Hi Igniters, Vyacheslav,
>> > > >
>> > > > I had discussion about this plugin. As GridGain representative I
>> > approve
>> > > > change of file headers and making this tool fully opensource.
>> > > >
>> > > > So please proceed with distributive build.
>> > > >
>> > > > Best Regards,
>> > > > Dmitriy Palvov
>> > > >
>> > > >
>> > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov
>> > > > <dp...@gmail.com>
>> > > > wrote:
>> > > >
>> > > >>
>> > > >>
>> > > >> ---------- Forwarded message ---------
>> > > >> From: Andrey Gura <ag...@apache.org>
>> > > >> Date: ср, 4 апр. 2018 г. в 12:05
>> > > >> Subject: Re: abbrevation rules plugin
>> > > >> To: <de...@ignite.apache.org>
>> > > >>
>> > > >>
>> > > >> Both prefixes "Grid" and "Ignite" in class names are redundant for
>> > most
>> > > >> cases. So there is no any rules for this.
>> > > >>
>> > > >> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
>> > > >>
>> > > >> > Hi, Igniters!
>> > > >> >
>> > > >> > I got into the task [1] in agreement with Dmitry.
>> > > >> >
>> > > >> > I’ve prepared the PR [2] with following changes:
>> > > >> > - added Apache 2.0 license to the header of each file
>> > > >> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
>> > > >> > - added README.md with a simple description
>> > > >> > - changed version 2.6.3 -> 3.0.0 because the project has own
>> > > >> > GitHub
>> > > >> > releases tab and completely new versioning isn't preferable IMO
>> > > >> >
>> > > >> > Also, I’ve built new artifact and tested it, it works well.
>> > > >> >
>> > > >> > Am I understood the task correct?
>> > > >> > If not, please share your notes I will fix them shortly.
>> > > >> >
>> > > >> > As far as I understand someone of GridGain employee should
>> > > >> > confirm
>> > the
>> > > >> > plugin's code's donation. It’d be great to confirm that by
>> > > >> > corporate
>> > > >> > email.
>> > > >> >
>> > > >> >
>> > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
>> > > >> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
>> > > >> >
>> > > >> >
>> > > >> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <
>> > dpavlov.spb@gmail.com
>> > > >
>> > > >> > wrote:
>> > > >> > > Hi Dmitriy, Denis,
>> > > >> > >
>> > > >> > > Thank you for your effort to find out solution.
>> > > >> > > It sound good for me, I have assigned IGNITE-5698 to myself.
>> > > >> > >
>> > > >> > > Best Regards,
>> > > >> > > Dmitriy Pavlov
>> > > >> > >
>> > > >> > >
>> > > >> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
>> > > >> > >
>> > > >> > >> Dmitriy P.,
>> > > >> > >>
>> > > >> > >> Does it sound good to you? If yes, please make sure the plugin
>> > > >> > >> is
>> > > >> > >> available via a public GitHub repo and refer to it from the
>> > > >> > >> doc.
>> > > >> > >>
>> > > >> > >> —
>> > > >> > >> Denis
>> > > >> > >>
>> > > >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
>> > > >> dsetrakyan@apache.org>
>> > > >> > >> wrote:
>> > > >> > >> >
>> > > >> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda
>> > > >> > >> > <dmagda@apache.org
>> > >
>> > > >> > wrote:
>> > > >> > >> >
>> > > >> > >> >> Ok, what if we make sure the plugin is available on GitHub
>> > (not
>> > > >> > Ignite)
>> > > >> > >> >> and give a link to it on the documentation page? This seems
>> > > >> > >> >> to
>> > > be
>> > > >> the
>> > > >> > >> >> easiest way to handle the topic.
>> > > >> > >> >
>> > > >> > >> >
>> > > >> > >> > I think this will work.
>> > > >> > >>
>> > > >> > >>
>> > > >> >
>> > > >> >
>> > > >>
>> > > >> >
>> > > >> > --
>> > > >> > Best Regards, Vyacheslav D.
>> > > >> >
>> > > >>
>> > > >
>> > >
>> >



-- 
Best Regards, Vyacheslav D.

Re: abbrevation rules plugin

Posted by Dmitry Pavlov <dp...@gmail.com>.
Anton, thank you for pointing to this.

I've updated wiki page with build and references:
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules

and attached jar file
https://cwiki.apache.org/confluence/pages/viewpageattachments.action?pageId=57901460


Thanks to Vyacheslav plugin is now published.

Sincerely,
Dmitriy Pavlov


пн, 14 мая 2018 г. в 19:14, Anton Vinogradov <av...@apache.org>:

> Jar already attached to issue :)
>
> see https://issues.apache.org/jira/browse/IGNITE-5698
>
> пн, 14 мая 2018 г. в 19:05, Dmitry Pavlov <dp...@gmail.com>:
>
> > Hi Folks,
> >
> > I suggest to keep it in https://github.com/dspavlov/ignite-abbrev-plugin
> > for
> > the beginning. Late we can consider Apache repo.
> >
> > But for wiki I need some distribution to attach first.
> >
> > Vyacheslav, could you remind me if we already have one?
> >
> > пн, 14 мая 2018 г. в 19:00, Anton Vinogradov <av...@apache.org>:
> >
> > > Awesome!
> > >
> > > Let's mention it officially on wiki.
> > > Do we need special apache repo for this plugin? As for me, public
> github
> > > repo is enough.
> > >
> > > пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dp...@gridgain.com>:
> > >
> > > > Hi Igniters, Vyacheslav,
> > > >
> > > > I had discussion about this plugin. As GridGain representative I
> > approve
> > > > change of file headers and making this tool fully opensource.
> > > >
> > > > So please proceed with distributive build.
> > > >
> > > > Best Regards,
> > > > Dmitriy Palvov
> > > >
> > > >
> > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dpavlov.spb@gmail.com
> >
> > > > wrote:
> > > >
> > > >>
> > > >>
> > > >> ---------- Forwarded message ---------
> > > >> From: Andrey Gura <ag...@apache.org>
> > > >> Date: ср, 4 апр. 2018 г. в 12:05
> > > >> Subject: Re: abbrevation rules plugin
> > > >> To: <de...@ignite.apache.org>
> > > >>
> > > >>
> > > >> Both prefixes "Grid" and "Ignite" in class names are redundant for
> > most
> > > >> cases. So there is no any rules for this.
> > > >>
> > > >> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
> > > >>
> > > >> > Hi, Igniters!
> > > >> >
> > > >> > I got into the task [1] in agreement with Dmitry.
> > > >> >
> > > >> > I’ve prepared the PR [2] with following changes:
> > > >> > - added Apache 2.0 license to the header of each file
> > > >> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > > >> > - added README.md with a simple description
> > > >> > - changed version 2.6.3 -> 3.0.0 because the project has own
> GitHub
> > > >> > releases tab and completely new versioning isn't preferable IMO
> > > >> >
> > > >> > Also, I’ve built new artifact and tested it, it works well.
> > > >> >
> > > >> > Am I understood the task correct?
> > > >> > If not, please share your notes I will fix them shortly.
> > > >> >
> > > >> > As far as I understand someone of GridGain employee should confirm
> > the
> > > >> > plugin's code's donation. It’d be great to confirm that by
> corporate
> > > >> > email.
> > > >> >
> > > >> >
> > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > > >> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> > > >> >
> > > >> >
> > > >> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <
> > dpavlov.spb@gmail.com
> > > >
> > > >> > wrote:
> > > >> > > Hi Dmitriy, Denis,
> > > >> > >
> > > >> > > Thank you for your effort to find out solution.
> > > >> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > > >> > >
> > > >> > > Best Regards,
> > > >> > > Dmitriy Pavlov
> > > >> > >
> > > >> > >
> > > >> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> > > >> > >
> > > >> > >> Dmitriy P.,
> > > >> > >>
> > > >> > >> Does it sound good to you? If yes, please make sure the plugin
> is
> > > >> > >> available via a public GitHub repo and refer to it from the
> doc.
> > > >> > >>
> > > >> > >> —
> > > >> > >> Denis
> > > >> > >>
> > > >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> > > >> dsetrakyan@apache.org>
> > > >> > >> wrote:
> > > >> > >> >
> > > >> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <
> dmagda@apache.org
> > >
> > > >> > wrote:
> > > >> > >> >
> > > >> > >> >> Ok, what if we make sure the plugin is available on GitHub
> > (not
> > > >> > Ignite)
> > > >> > >> >> and give a link to it on the documentation page? This seems
> to
> > > be
> > > >> the
> > > >> > >> >> easiest way to handle the topic.
> > > >> > >> >
> > > >> > >> >
> > > >> > >> > I think this will work.
> > > >> > >>
> > > >> > >>
> > > >> >
> > > >> >
> > > >>
> > > >> >
> > > >> > --
> > > >> > Best Regards, Vyacheslav D.
> > > >> >
> > > >>
> > > >
> > >
> >
>

Re: abbrevation rules plugin

Posted by Anton Vinogradov <av...@apache.org>.
Jar already attached to issue :)

see https://issues.apache.org/jira/browse/IGNITE-5698

пн, 14 мая 2018 г. в 19:05, Dmitry Pavlov <dp...@gmail.com>:

> Hi Folks,
>
> I suggest to keep it in https://github.com/dspavlov/ignite-abbrev-plugin
> for
> the beginning. Late we can consider Apache repo.
>
> But for wiki I need some distribution to attach first.
>
> Vyacheslav, could you remind me if we already have one?
>
> пн, 14 мая 2018 г. в 19:00, Anton Vinogradov <av...@apache.org>:
>
> > Awesome!
> >
> > Let's mention it officially on wiki.
> > Do we need special apache repo for this plugin? As for me, public github
> > repo is enough.
> >
> > пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dp...@gridgain.com>:
> >
> > > Hi Igniters, Vyacheslav,
> > >
> > > I had discussion about this plugin. As GridGain representative I
> approve
> > > change of file headers and making this tool fully opensource.
> > >
> > > So please proceed with distributive build.
> > >
> > > Best Regards,
> > > Dmitriy Palvov
> > >
> > >
> > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dp...@gmail.com>
> > > wrote:
> > >
> > >>
> > >>
> > >> ---------- Forwarded message ---------
> > >> From: Andrey Gura <ag...@apache.org>
> > >> Date: ср, 4 апр. 2018 г. в 12:05
> > >> Subject: Re: abbrevation rules plugin
> > >> To: <de...@ignite.apache.org>
> > >>
> > >>
> > >> Both prefixes "Grid" and "Ignite" in class names are redundant for
> most
> > >> cases. So there is no any rules for this.
> > >>
> > >> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
> > >>
> > >> > Hi, Igniters!
> > >> >
> > >> > I got into the task [1] in agreement with Dmitry.
> > >> >
> > >> > I’ve prepared the PR [2] with following changes:
> > >> > - added Apache 2.0 license to the header of each file
> > >> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > >> > - added README.md with a simple description
> > >> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> > >> > releases tab and completely new versioning isn't preferable IMO
> > >> >
> > >> > Also, I’ve built new artifact and tested it, it works well.
> > >> >
> > >> > Am I understood the task correct?
> > >> > If not, please share your notes I will fix them shortly.
> > >> >
> > >> > As far as I understand someone of GridGain employee should confirm
> the
> > >> > plugin's code's donation. It’d be great to confirm that by corporate
> > >> > email.
> > >> >
> > >> >
> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > >> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> > >> >
> > >> >
> > >> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <
> dpavlov.spb@gmail.com
> > >
> > >> > wrote:
> > >> > > Hi Dmitriy, Denis,
> > >> > >
> > >> > > Thank you for your effort to find out solution.
> > >> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > >> > >
> > >> > > Best Regards,
> > >> > > Dmitriy Pavlov
> > >> > >
> > >> > >
> > >> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> > >> > >
> > >> > >> Dmitriy P.,
> > >> > >>
> > >> > >> Does it sound good to you? If yes, please make sure the plugin is
> > >> > >> available via a public GitHub repo and refer to it from the doc.
> > >> > >>
> > >> > >> —
> > >> > >> Denis
> > >> > >>
> > >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> > >> dsetrakyan@apache.org>
> > >> > >> wrote:
> > >> > >> >
> > >> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dmagda@apache.org
> >
> > >> > wrote:
> > >> > >> >
> > >> > >> >> Ok, what if we make sure the plugin is available on GitHub
> (not
> > >> > Ignite)
> > >> > >> >> and give a link to it on the documentation page? This seems to
> > be
> > >> the
> > >> > >> >> easiest way to handle the topic.
> > >> > >> >
> > >> > >> >
> > >> > >> > I think this will work.
> > >> > >>
> > >> > >>
> > >> >
> > >> >
> > >>
> > >> >
> > >> > --
> > >> > Best Regards, Vyacheslav D.
> > >> >
> > >>
> > >
> >
>

Re: abbrevation rules plugin

Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Folks,

I suggest to keep it in https://github.com/dspavlov/ignite-abbrev-plugin for
the beginning. Late we can consider Apache repo.

But for wiki I need some distribution to attach first.

Vyacheslav, could you remind me if we already have one?

пн, 14 мая 2018 г. в 19:00, Anton Vinogradov <av...@apache.org>:

> Awesome!
>
> Let's mention it officially on wiki.
> Do we need special apache repo for this plugin? As for me, public github
> repo is enough.
>
> пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dp...@gridgain.com>:
>
> > Hi Igniters, Vyacheslav,
> >
> > I had discussion about this plugin. As GridGain representative I approve
> > change of file headers and making this tool fully opensource.
> >
> > So please proceed with distributive build.
> >
> > Best Regards,
> > Dmitriy Palvov
> >
> >
> > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> >>
> >>
> >> ---------- Forwarded message ---------
> >> From: Andrey Gura <ag...@apache.org>
> >> Date: ср, 4 апр. 2018 г. в 12:05
> >> Subject: Re: abbrevation rules plugin
> >> To: <de...@ignite.apache.org>
> >>
> >>
> >> Both prefixes "Grid" and "Ignite" in class names are redundant for most
> >> cases. So there is no any rules for this.
> >>
> >> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
> >>
> >> > Hi, Igniters!
> >> >
> >> > I got into the task [1] in agreement with Dmitry.
> >> >
> >> > I’ve prepared the PR [2] with following changes:
> >> > - added Apache 2.0 license to the header of each file
> >> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> >> > - added README.md with a simple description
> >> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> >> > releases tab and completely new versioning isn't preferable IMO
> >> >
> >> > Also, I’ve built new artifact and tested it, it works well.
> >> >
> >> > Am I understood the task correct?
> >> > If not, please share your notes I will fix them shortly.
> >> >
> >> > As far as I understand someone of GridGain employee should confirm the
> >> > plugin's code's donation. It’d be great to confirm that by corporate
> >> > email.
> >> >
> >> >
> >> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> >> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> >> >
> >> >
> >> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dpavlov.spb@gmail.com
> >
> >> > wrote:
> >> > > Hi Dmitriy, Denis,
> >> > >
> >> > > Thank you for your effort to find out solution.
> >> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> >> > >
> >> > > Best Regards,
> >> > > Dmitriy Pavlov
> >> > >
> >> > >
> >> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> >> > >
> >> > >> Dmitriy P.,
> >> > >>
> >> > >> Does it sound good to you? If yes, please make sure the plugin is
> >> > >> available via a public GitHub repo and refer to it from the doc.
> >> > >>
> >> > >> —
> >> > >> Denis
> >> > >>
> >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> >> dsetrakyan@apache.org>
> >> > >> wrote:
> >> > >> >
> >> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> >> > wrote:
> >> > >> >
> >> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
> >> > Ignite)
> >> > >> >> and give a link to it on the documentation page? This seems to
> be
> >> the
> >> > >> >> easiest way to handle the topic.
> >> > >> >
> >> > >> >
> >> > >> > I think this will work.
> >> > >>
> >> > >>
> >> >
> >> >
> >>
> >> >
> >> > --
> >> > Best Regards, Vyacheslav D.
> >> >
> >>
> >
>

Re: abbrevation rules plugin

Posted by Anton Vinogradov <av...@apache.org>.
Awesome!

Let's mention it officially on wiki.
Do we need special apache repo for this plugin? As for me, public github
repo is enough.

пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dp...@gridgain.com>:

> Hi Igniters, Vyacheslav,
>
> I had discussion about this plugin. As GridGain representative I approve
> change of file headers and making this tool fully opensource.
>
> So please proceed with distributive build.
>
> Best Regards,
> Dmitriy Palvov
>
>
> On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
>>
>>
>> ---------- Forwarded message ---------
>> From: Andrey Gura <ag...@apache.org>
>> Date: ср, 4 апр. 2018 г. в 12:05
>> Subject: Re: abbrevation rules plugin
>> To: <de...@ignite.apache.org>
>>
>>
>> Both prefixes "Grid" and "Ignite" in class names are redundant for most
>> cases. So there is no any rules for this.
>>
>> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
>>
>> > Hi, Igniters!
>> >
>> > I got into the task [1] in agreement with Dmitry.
>> >
>> > I’ve prepared the PR [2] with following changes:
>> > - added Apache 2.0 license to the header of each file
>> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
>> > - added README.md with a simple description
>> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
>> > releases tab and completely new versioning isn't preferable IMO
>> >
>> > Also, I’ve built new artifact and tested it, it works well.
>> >
>> > Am I understood the task correct?
>> > If not, please share your notes I will fix them shortly.
>> >
>> > As far as I understand someone of GridGain employee should confirm the
>> > plugin's code's donation. It’d be great to confirm that by corporate
>> > email.
>> >
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
>> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
>> >
>> >
>> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
>> > wrote:
>> > > Hi Dmitriy, Denis,
>> > >
>> > > Thank you for your effort to find out solution.
>> > > It sound good for me, I have assigned IGNITE-5698 to myself.
>> > >
>> > > Best Regards,
>> > > Dmitriy Pavlov
>> > >
>> > >
>> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
>> > >
>> > >> Dmitriy P.,
>> > >>
>> > >> Does it sound good to you? If yes, please make sure the plugin is
>> > >> available via a public GitHub repo and refer to it from the doc.
>> > >>
>> > >> —
>> > >> Denis
>> > >>
>> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
>> dsetrakyan@apache.org>
>> > >> wrote:
>> > >> >
>> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
>> > wrote:
>> > >> >
>> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
>> > Ignite)
>> > >> >> and give a link to it on the documentation page? This seems to be
>> the
>> > >> >> easiest way to handle the topic.
>> > >> >
>> > >> >
>> > >> > I think this will work.
>> > >>
>> > >>
>> >
>> >
>>
>> >
>> > --
>> > Best Regards, Vyacheslav D.
>> >
>>
>

Re: abbrevation rules plugin

Posted by Dmitriy Pavlov <dp...@gridgain.com>.
Hi Igniters, Vyacheslav,

I had discussion about this plugin. As GridGain representative I approve
change of file headers and making this tool fully opensource.

So please proceed with distributive build.

Best Regards,
Dmitriy Palvov


On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dp...@gmail.com> wrote:

>
>
> ---------- Forwarded message ---------
> From: Andrey Gura <ag...@apache.org>
> Date: ср, 4 апр. 2018 г. в 12:05
> Subject: Re: abbrevation rules plugin
> To: <de...@ignite.apache.org>
>
>
> Both prefixes "Grid" and "Ignite" in class names are redundant for most
> cases. So there is no any rules for this.
>
> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:
>
> > Hi, Igniters!
> >
> > I got into the task [1] in agreement with Dmitry.
> >
> > I’ve prepared the PR [2] with following changes:
> > - added Apache 2.0 license to the header of each file
> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > - added README.md with a simple description
> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> > releases tab and completely new versioning isn't preferable IMO
> >
> > Also, I’ve built new artifact and tested it, it works well.
> >
> > Am I understood the task correct?
> > If not, please share your notes I will fix them shortly.
> >
> > As far as I understand someone of GridGain employee should confirm the
> > plugin's code's donation. It’d be great to confirm that by corporate
> > email.
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> >
> >
> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> > > Hi Dmitriy, Denis,
> > >
> > > Thank you for your effort to find out solution.
> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > >
> > > Best Regards,
> > > Dmitriy Pavlov
> > >
> > >
> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> > >
> > >> Dmitriy P.,
> > >>
> > >> Does it sound good to you? If yes, please make sure the plugin is
> > >> available via a public GitHub repo and refer to it from the doc.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > >> wrote:
> > >> >
> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> > wrote:
> > >> >
> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
> > Ignite)
> > >> >> and give a link to it on the documentation page? This seems to be
> the
> > >> >> easiest way to handle the topic.
> > >> >
> > >> >
> > >> > I think this will work.
> > >>
> > >>
> >
> >
>
> >
> > --
> > Best Regards, Vyacheslav D.
> >
>

Re: abbrevation rules plugin

Posted by Andrey Gura <ag...@apache.org>.
Both prefixes "Grid" and "Ignite" in class names are redundant for most
cases. So there is no any rules for this.

вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <da...@gmail.com>:

> Hi, Igniters!
>
> I got into the task [1] in agreement with Dmitry.
>
> I’ve prepared the PR [2] with following changes:
> - added Apache 2.0 license to the header of each file
> - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> - added README.md with a simple description
> - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> releases tab and completely new versioning isn't preferable IMO
>
> Also, I’ve built new artifact and tested it, it works well.
>
> Am I understood the task correct?
> If not, please share your notes I will fix them shortly.
>
> As far as I understand someone of GridGain employee should confirm the
> plugin's code's donation. It’d be great to confirm that by corporate
> email.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-5698
> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
>
>
> On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
> > Hi Dmitriy, Denis,
> >
> > Thank you for your effort to find out solution.
> > It sound good for me, I have assigned IGNITE-5698 to myself.
> >
> > Best Regards,
> > Dmitriy Pavlov
> >
> >
> > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dm...@apache.org>:
> >
> >> Dmitriy P.,
> >>
> >> Does it sound good to you? If yes, please make sure the plugin is
> >> available via a public GitHub repo and refer to it from the doc.
> >>
> >> —
> >> Denis
> >>
> >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <ds...@apache.org>
> >> wrote:
> >> >
> >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <dm...@apache.org>
> wrote:
> >> >
> >> >> Ok, what if we make sure the plugin is available on GitHub (not
> Ignite)
> >> >> and give a link to it on the documentation page? This seems to be the
> >> >> easiest way to handle the topic.
> >> >
> >> >
> >> > I think this will work.
> >>
> >>
>
>
>
> --
> Best Regards, Vyacheslav D.
>