Re: [PR] [AMORO-3775] Add support for metric-based refresh event trigger in TableRuntimeRefreshExecutor [amoro]

["Jzjsnow (via GitHub)" <gi...@apache.org>]

Jzjsnow commented on code in PR #3776:
URL: https://github.com/apache/amoro/pull/3776#discussion_r2544771063


##########
amoro-format-iceberg/src/main/java/org/apache/amoro/table/TableProperties.java:
##########
@@ -133,6 +134,19 @@ private TableProperties() {}
       "self-optimizing.min-plan-interval";
   public static final long SELF_OPTIMIZING_MIN_PLAN_INTERVAL_DEFAULT = 60000;
 
+  /** metric-based evaluation related properties */
+  public static final String SELF_OPTIMIZING_EVALUATION_AVERAGE_FILE_SIZE_TOLERANCE =
+      "self-optimizing.evaluation.average-file-size.tolerance"; // the minimum tolerance value for
+  // the average
+  // partition file size (between 0 and (self-optimizing.target-size))
+  public static final MemorySize SELF_OPTIMIZING_EVALUATION_AVERAGE_FILE_SIZE_TOLERANCE_DEFAULT =

Review Comment:
   Thanks for the suggestion. I have updated the variable to `self-optimising.evaluation.file-size.mse-tolerance` and specified bytes as the unit. This renders the variable name more clearly legible and aligns the unit with other size parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org