You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/01/19 12:15:00 UTC

[jira] [Commented] (KNOX-2748) HashicorpVaultAliasService getPasswordFromAliasForCluster looks incorrecct

    [ https://issues.apache.org/jira/browse/KNOX-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678661#comment-17678661 ] 

ASF subversion and git services commented on KNOX-2748:
-------------------------------------------------------

Commit 359f12a1a1f5f0e3386ca9838d5409caf763fa14 in knox's branch refs/heads/master from MrtnBalazs
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=359f12a1a ]

KNOX-2748 - Fixed HashiCorp alias service getPasswordFromAliasForCluster (#716)

* KNOX-2748 - Fixed HashiCorp alias service getPasswordFromAliasForCluster

* KNOX-2748 - Fixed PMD and formatting

* KNOX-2748 - Added not equals assertion to the test.

> HashicorpVaultAliasService getPasswordFromAliasForCluster looks incorrecct
> --------------------------------------------------------------------------
>
>                 Key: KNOX-2748
>                 URL: https://issues.apache.org/jira/browse/KNOX-2748
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Attila Magyar
>            Assignee: Marton Balázs
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> {code}
>   @Override
>   public char[] getPasswordFromAliasForCluster(String clusterName, String alias, boolean generate) throws AliasServiceException {
>     if(generate) {
>       getPasswordFromAliasForCluster(clusterName, alias);
>     }
>     return getPasswordFromAliasForCluster(clusterName, alias); // this is just the same method as above
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)