You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "preaudc (via GitHub)" <gi...@apache.org> on 2023/04/05 16:05:09 UTC
[GitHub] [iceberg] preaudc opened a new pull request, #7282: Docs: clarify Hive on Tez configuration
preaudc opened a new pull request, #7282:
URL: https://github.com/apache/iceberg/pull/7282
I had the impression that the original sentence (`You will also need to set the following property in the Hive configuration: tez.mrreader.config.update.properties=hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids.`) meant that this configuration was needed for the Tez engine on Hive 2.3.x only.
Besides, I thought that `Hive configuration` meant `hive-site.xml` rather than `tez-site.xml`.
Hence, I propose this change in wording to make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7282: Docs: clarify Hive on Tez configuration
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7282:
URL: https://github.com/apache/iceberg/pull/7282#discussion_r1162136411
##########
docs/hive.md:
##########
@@ -127,12 +127,11 @@ The table level configuration overrides the global Hadoop configuration.
To use the Tez engine on Hive `3.1.2` or later, Tez needs to be upgraded to >= `0.10.1` which contains a necessary fix [TEZ-4248](https://issues.apache.org/jira/browse/TEZ-4248).
-
To use the Tez engine on Hive `2.3.x`, you will need to manually build Tez from the `branch-0.9` branch due to a
backwards incompatibility issue with Tez `0.10.1`.
-You will also need to set the following property in the Hive
-configuration: `tez.mrreader.config.update.properties=hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids`.
+In both cases, you will also need to set the following property in the `tez-site.xml` configuration
+file: `tez.mrreader.config.update.properties=hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids`.
Review Comment:
@preaudc thanks for raising this. Could you remove the line break?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #7282: Docs: clarify Hive on Tez configuration
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #7282:
URL: https://github.com/apache/iceberg/pull/7282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] preaudc commented on a diff in pull request #7282: Docs: clarify Hive on Tez configuration
Posted by "preaudc (via GitHub)" <gi...@apache.org>.
preaudc commented on code in PR #7282:
URL: https://github.com/apache/iceberg/pull/7282#discussion_r1163255545
##########
docs/hive.md:
##########
@@ -127,12 +127,11 @@ The table level configuration overrides the global Hadoop configuration.
To use the Tez engine on Hive `3.1.2` or later, Tez needs to be upgraded to >= `0.10.1` which contains a necessary fix [TEZ-4248](https://issues.apache.org/jira/browse/TEZ-4248).
-
To use the Tez engine on Hive `2.3.x`, you will need to manually build Tez from the `branch-0.9` branch due to a
backwards incompatibility issue with Tez `0.10.1`.
-You will also need to set the following property in the Hive
-configuration: `tez.mrreader.config.update.properties=hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids`.
+In both cases, you will also need to set the following property in the `tez-site.xml` configuration
+file: `tez.mrreader.config.update.properties=hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids`.
Review Comment:
Thanks for the review @Fokko !
Sure, is that ok now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org