You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Ernie Allen <ea...@redhat.com> on 2015/06/20 01:45:38 UTC
Review Request 35675: Add graph attribute to schema entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35675/
-----------------------------------------------------------
Review request for qpid, Alan Conway and Ted Ross.
Repository: qpid-dispatch
Description
-------
Add a new attribute named "graph" to the graphable entities in the schema.
Diffs
-----
trunk/python/qpid_dispatch/management/qdrouter.json 1686514
trunk/python/qpid_dispatch_internal/management/schema.py 1686514
Diff: https://reviews.apache.org/r/35675/diff/
Testing
-------
bin/test.sh builds and runs the tests without errors.
The management call to get the schema now returns the new graph attribute.
Thanks,
Ernie Allen
Re: Review Request 35675: Add graph attribute to schema entities
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35675/#review88826
-----------------------------------------------------------
Ship it!
Ship It!
- Alan Conway
On June 19, 2015, 11:45 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35675/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 11:45 p.m.)
>
>
> Review request for qpid, Alan Conway and Ted Ross.
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Add a new attribute named "graph" to the graphable entities in the schema.
>
>
> Diffs
> -----
>
> trunk/python/qpid_dispatch/management/qdrouter.json 1686514
> trunk/python/qpid_dispatch_internal/management/schema.py 1686514
>
> Diff: https://reviews.apache.org/r/35675/diff/
>
>
> Testing
> -------
>
> bin/test.sh builds and runs the tests without errors.
> The management call to get the schema now returns the new graph attribute.
>
>
> Thanks,
>
> Ernie Allen
>
>
Re: Review Request 35675: Add graph attribute to schema entities
Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35675/#review88837
-----------------------------------------------------------
Ship it!
Looks ok to me
- Ted Ross
On June 19, 2015, 7:45 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35675/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 7:45 p.m.)
>
>
> Review request for qpid, Alan Conway and Ted Ross.
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Add a new attribute named "graph" to the graphable entities in the schema.
>
>
> Diffs
> -----
>
> trunk/python/qpid_dispatch/management/qdrouter.json 1686514
> trunk/python/qpid_dispatch_internal/management/schema.py 1686514
>
> Diff: https://reviews.apache.org/r/35675/diff/
>
>
> Testing
> -------
>
> bin/test.sh builds and runs the tests without errors.
> The management call to get the schema now returns the new graph attribute.
>
>
> Thanks,
>
> Ernie Allen
>
>