You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2014/08/23 11:44:11 UTC

[jira] [Commented] (LANG-1012) Add Validate.isFalse, Validate.largerThan and Validate.smallerThan

    [ https://issues.apache.org/jira/browse/LANG-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107954#comment-14107954 ] 

Benedikt Ritter commented on LANG-1012:
---------------------------------------

IMHO the isFalse method is useful. However I think {{Validate.isTrue(x > y)}} is enough. Because you will run into the problem that you sometimes need greaterThan and somethimes greaterOrEqual... Using the above method it simply becomes x > y or x >= y :)

> Add Validate.isFalse, Validate.largerThan and Validate.smallerThan
> ------------------------------------------------------------------
>
>                 Key: LANG-1012
>                 URL: https://issues.apache.org/jira/browse/LANG-1012
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.3.2
>            Reporter: Duncan Jones
>            Assignee: Duncan Jones
>            Priority: Minor
>             Fix For: Discussion
>
>
> It would be more natural to express certain conditions if we offered the following new methods in {{Validate}}:
> {code:java}
> Validate.isFalse(boolean expression, String message, Object... values)
> Validate.largerThan(long minExclusive, long value, String message, Object... values)
> Validate.smallerThan(long maxExclusive, long value, String message, Object... values)
> {code}
> The usual variants of these methods are also required (using {{double}}, {{T}} etc.).



--
This message was sent by Atlassian JIRA
(v6.2#6252)