You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Nils-Helge Garli (JIRA)" <ji...@codehaus.org> on 2008/02/16 21:36:28 UTC
[jira] Created: (SUREFIRE-459) Integration test using Jetty and JSP
2.1 fails after update to maven-surefire-plugin 2.4
Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
----------------------------------------------------------------------------------------
Key: SUREFIRE-459
URL: http://jira.codehaus.org/browse/SUREFIRE-459
Project: Maven Surefire
Issue Type: Bug
Components: classloading, plugin
Affects Versions: 2.4.1, 2.4
Environment: Maven 2.0.8, Windows XP
Reporter: Nils-Helge Garli
We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (SUREFIRE-459) Integration test using
Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Chris Beams (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146867#action_146867 ]
cbeams edited comment on SUREFIRE-459 at 9/3/08 1:27 PM:
--------------------------------------------------------------
It appears that I've just reproduced this bug against 2.4.3. I've tried the 'useSystemClassLoader=false' workaround, and it exposes a different problem. Unfortunately this issue is 'closed' and so cannot be re-opened. Shall I create a new issue?
At any rate, here are the repro steps:
1) Check out, build and test Spring JavaConfig's petclinic sample:
svn co -r 789 https://src.springframework.org/svn/spring-javaconfig/trunk/samples/org.springframework.config.java.samples.petclinic petclinic
cd petclinic
mvn clean test
2) Notice that there are two test failures:
Tests in error:
testIndex(test.web.InContainerTests)
testFindOwners(test.web.InContainerTests)
The cause of both these issues is the following:
Error 500 /WEB-INF/jsp/includes.jsp(1,70) PWC6188: The absolute uri: http://www.springframework.org/tags cannot be resolved in either web.xml or the jar files deployed with this application
As mentioned above, downgrading to 2.3 does work - the tests pass once I do this. (See revision 790 of the above to confirm).
was (Author: cbeams):
It appears that I've just reproduced this bug against 2.4.3. I've tried the 'useSystemClassLoader=false' workaround, and it exposes a different problem. Unfortunately this issue is 'closed' and so cannot be re-opened. Shall I create a new issue?
At any rate, here are the repro steps:
1) Check out, build and test Spring JavaConfig's petclinic sample:
svn co -r 789 https://src.springframework.org/svn/spring-javaconfig/trunk/samples/org.springframework.config.java.samples.petclinic petclinic
cd petclinic
mvn clean test
2) Notice that there are two test failures:
Tests in error:
testIndex(test.web.InContainerTests)
testFindOwners(test.web.InContainerTests)
The cause of both these issues is the following:
Error 500 /WEB-INF/jsp/includes.jsp(1,70) PWC6188: The absolute uri: http://www.springframework.org/tags cannot be resolved in either web.xml or the jar files deployed with this application
As mentioned above, downgrading to 2.3 does work - the tests pass once I do this. (See revision 780 of the above to confirm).
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
> Fix For: 2.4.3
>
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-459) Integration test using Jetty and
JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Nils-Helge Garli (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124433 ]
Nils-Helge Garli commented on SUREFIRE-459:
-------------------------------------------
Sorry for not beeing more specific. Anyway, it appears that this has been resolved in the 2.4.2-SNAPSHOT. I will re-test it when 2.4.2 is released to make sure it's still ok.
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-459) Integration test using Jetty and
JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Chris Beams (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146867#action_146867 ]
Chris Beams commented on SUREFIRE-459:
--------------------------------------
It appears that I've just reproduced this bug against 2.4.3. I've tried the 'useSystemClassLoader=false' workaround, and it exposes a different problem. Unfortunately this issue is 'closed' and so cannot be re-opened. Shall I create a new issue?
At any rate, here are the repro steps:
1) Check out, build and test Spring JavaConfig's petclinic sample:
svn co -r 789 https://src.springframework.org/svn/spring-javaconfig/trunk/samples/org.springframework.config.java.samples.petclinic petclinic
cd petclinic
mvn clean test
2) Notice that there are two test failures:
Tests in error:
testIndex(test.web.InContainerTests)
testFindOwners(test.web.InContainerTests)
The cause of both these issues is the following:
Error 500 /WEB-INF/jsp/includes.jsp(1,70) PWC6188: The absolute uri: http://www.springframework.org/tags cannot be resolved in either web.xml or the jar files deployed with this application
As mentioned above, downgrading to 2.3 does work - the tests pass once I do this. (See revision 780 of the above to confirm).
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
> Fix For: 2.4.3
>
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-459) Integration test using Jetty and
JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124423 ]
Dan Fabulich commented on SUREFIRE-459:
---------------------------------------
Rather than just grabbing the current latest (which might be broken for some other reason), could you give me a specific SVN URL and revision number to pull down?
Prior to knowing anything else about your failing test, I might suggest that you take a look at SUREFIRE-453 and try configuring 2.4 with useSystemClassLoader=false.
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SUREFIRE-459) Integration test using Jetty and JSP
2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich closed SUREFIRE-459.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.5
Fixed in revision 642046. By default forkMode=once and useSystemclassloader=true, which causes us to launch the tests using a a manifest-only jar; this confuses Jetty when it uses the system property "java.class.path" to javac to compile JSPs.
Fixed by deliberately "faking out" the java.class.path, setting it to what the classpath would have been if we'd launched the app in a conventional way. This also has the benefit of more generally insulating our users from the manifest-only jar; java.class.path will look "normal" now.
In the short term, there is an easy workaround for this, which is to set useSystemClassLoader=false. (My initial guess was correct.)
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
> Fix For: 2.5
>
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-459) Integration test using Jetty and
JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146924#action_146924 ]
Dan Fabulich commented on SUREFIRE-459:
---------------------------------------
Yes, file a separate issue. But before you do, be sure to read this: http://maven.apache.org/plugins/maven-surefire-plugin/examples/class-loading.html
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
> Fix For: 2.4.3
>
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SUREFIRE-459) Integration test using Jetty and JSP
2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated SUREFIRE-459:
-----------------------------------
Fix Version/s: (was: 2.5)
2.4.3
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
> Fix For: 2.4.3
>
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (SUREFIRE-459) Integration test using Jetty and
JSP 2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich reopened SUREFIRE-459:
-----------------------------------
Assignee: Dan Fabulich
We just found a repro case for this at Redfin. I'll attach a sample that repro's the problem.
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
> Assignee: Dan Fabulich
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SUREFIRE-459) Integration test using Jetty and JSP
2.1 fails after update to maven-surefire-plugin 2.4
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich closed SUREFIRE-459.
---------------------------------
Resolution: Fixed
Marking Fixed
> Integration test using Jetty and JSP 2.1 fails after update to maven-surefire-plugin 2.4
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-459
> URL: http://jira.codehaus.org/browse/SUREFIRE-459
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, plugin
> Affects Versions: 2.4, 2.4.1
> Environment: Maven 2.0.8, Windows XP
> Reporter: Nils-Helge Garli
>
> We have an integration test running in a Struts 2 sample application, and after the maven-surefire-plugin was updated from 2.3 to 2.4, the test is failing. There's an issue registered in the Struts 2 JIRA explaining the error: https://issues.apache.org/struts/browse/WW-2494
> I have no idea what's causing the error, but I suspect it has something to do witn classloader configuration, as aparently no tld files are found inside the jar files on the classpath.
> It should be pretty easy to reproduce. Just checkout the Struts 2 code and run 'mvn test' on the portlet example application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira