You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/12/08 22:59:29 UTC
Review Request 74248: RANGER-4008: updated RangerTagEnricher to ignore invalid resources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74248/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
Bugs: RANGER-4008
https://issues.apache.org/jira/browse/RANGER-4008
Repository: ranger
Description
-------
updated RangerTagEnricher to continue processing downloaded tag after ignoreing invalid resources
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 2e442c2d0
Diff: https://reviews.apache.org/r/74248/diff/1/
Testing
-------
- verified using docker setup that the plugins ignore invalid resource and enforce tag-based policies for other resources in tags downloaded from Ranger
Thanks,
Madhan Neethiraj
Re: Review Request 74248: RANGER-4008: updated RangerTagEnricher to ignore invalid resources
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Dec. 8, 2022, 11:38 p.m., Abhay Kulkarni wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
> > Line 435 (original), 434 (patched)
> > <https://reviews.apache.org/r/74248/diff/1/?file=2272583#file2272583line438>
> >
> > In the flow - tagSync->Ranger-Admin->plugin, what are the conditions under which an invalid service-resource may be encountered thereby causing the matcher to be null here?
Not via tagsync. Invalid service-resource in this case came via importTags() REST API. Ideally, importTags() must validate and fail such service-resources from entering Ranger. We can track this in a separate JIRA.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74248/#review224982
-----------------------------------------------------------
On Dec. 8, 2022, 10:59 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74248/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2022, 10:59 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4008
> https://issues.apache.org/jira/browse/RANGER-4008
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated RangerTagEnricher to continue processing downloaded tag after ignoreing invalid resources
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 2e442c2d0
>
>
> Diff: https://reviews.apache.org/r/74248/diff/1/
>
>
> Testing
> -------
>
> - verified using docker setup that the plugins ignore invalid resource and enforce tag-based policies for other resources in tags downloaded from Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74248: RANGER-4008: updated RangerTagEnricher to ignore invalid resources
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74248/#review224982
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
Line 435 (original), 434 (patched)
<https://reviews.apache.org/r/74248/#comment313807>
In the flow - tagSync->Ranger-Admin->plugin, what are the conditions under which an invalid service-resource may be encountered thereby causing the matcher to be null here?
- Abhay Kulkarni
On Dec. 8, 2022, 10:59 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74248/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2022, 10:59 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4008
> https://issues.apache.org/jira/browse/RANGER-4008
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated RangerTagEnricher to continue processing downloaded tag after ignoreing invalid resources
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 2e442c2d0
>
>
> Diff: https://reviews.apache.org/r/74248/diff/1/
>
>
> Testing
> -------
>
> - verified using docker setup that the plugins ignore invalid resource and enforce tag-based policies for other resources in tags downloaded from Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74248: RANGER-4008: updated RangerTagEnricher to ignore invalid resources
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74248/#review224991
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Dec. 8, 2022, 10:59 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74248/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2022, 10:59 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4008
> https://issues.apache.org/jira/browse/RANGER-4008
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated RangerTagEnricher to continue processing downloaded tag after ignoreing invalid resources
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 2e442c2d0
>
>
> Diff: https://reviews.apache.org/r/74248/diff/1/
>
>
> Testing
> -------
>
> - verified using docker setup that the plugins ignore invalid resource and enforce tag-based policies for other resources in tags downloaded from Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>