You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/01 12:16:57 UTC

[GitHub] [zeppelin] huage1994 opened a new pull request, #4392: [ZEPPELIN-5694] Support apache kyuubi

huage1994 opened a new pull request, #4392:
URL: https://github.com/apache/zeppelin/pull/4392

   ### What is this PR for?
   Give an example to use Apache Kyuubi in JDBC interpreter.
   
   ### What type of PR is it?
   Documentation
   
   *Please leave your type of PR only*
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5694
   
   ### How should this be tested?
   * CI passed
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] yaooqinn commented on a diff in pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#discussion_r913426811


##########
docs/interpreter/jdbc.md:
##########
@@ -827,6 +827,38 @@ Dependencies
   </tr>
 </table>
 
+### Apache Kyuubi
+
+Properties
+
+<table class="table-configuration">
+  <tr>
+    <th>Name</th>
+    <th>Value</th>
+  </tr>
+  <tr>
+    <td>default.driver</td>
+    <td>org.apache.hive.jdbc.HiveDriver</td>
+  </tr>
+  <tr>
+    <td>default.url</td>
+    <td>jdbc:hive2://kyuubi-server:2181/default;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=kyuubi</td>
+  </tr>
+</table>
+
+Dependencies
+
+<table class="table-configuration">
+  <tr>
+    <th>Artifact</th>
+    <th>Excludes</th>
+  </tr>
+  <tr>
+    <td>org.apache.hive:hive-jdbc:2.3.4</td>

Review Comment:
   cc @pan3793



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] zjffdu commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1250220039

   Sorry for the late response @huage1994 , PR LGTM, trigger the CI again and wait for its result before merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] zjffdu merged pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
zjffdu merged PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#discussion_r913429014


##########
docs/interpreter/jdbc.md:
##########
@@ -827,6 +827,38 @@ Dependencies
   </tr>
 </table>
 
+### Apache Kyuubi
+
+Properties
+
+<table class="table-configuration">
+  <tr>
+    <th>Name</th>
+    <th>Value</th>
+  </tr>
+  <tr>
+    <td>default.driver</td>
+    <td>org.apache.hive.jdbc.HiveDriver</td>
+  </tr>
+  <tr>
+    <td>default.url</td>
+    <td>jdbc:hive2://kyuubi-server:2181/default;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=kyuubi</td>
+  </tr>
+</table>
+
+Dependencies
+
+<table class="table-configuration">
+  <tr>
+    <th>Artifact</th>
+    <th>Excludes</th>
+  </tr>
+  <tr>
+    <td>org.apache.hive:hive-jdbc:2.3.4</td>

Review Comment:
   We recommend using `org.apache.kyuubi:kyuubi-hive-jdbc-shaded:1.5.2-incubating` to connect Kyuubi.
   
   https://kyuubi.readthedocs.io/en/latest/client/kyuubi_jdbc.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] zjffdu commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1172780521

   Thanks for the contribution @huage1994, is kerbose also supported? And it is better to give example how to enable kyuubi features via jdbc interpreter


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1251031730

   > Sorry for the late response @huage1994 , PR LGTM, trigger the CI again and wait for its result before merge
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-5694] Support apache kyuubi [zeppelin]

Posted by "smileyboy2019 (via GitHub)" <gi...@apache.org>.
smileyboy2019 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1844202604

   Can kyuubi be used in zeppelin? When will the new version be released?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-5694] Support apache kyuubi [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1844599686

   > Can kyuubi be used in zeppelin? When will the new version be released?
   
   It's already supported to use Kyuubi as a JDBC dialect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1235004458

   The CI is passed in my own forked repo. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1226704414

   > Thanks for the contribution @huage1994, is kerbose also supported? And it is better to give example how to enable kyuubi features via jdbc interpreter
   
   Hi @zjffdu , kerberos is supported now.  Could you help review that?
   Sorry for my late rely, 🤣 I met some problems with usage of Kerberos and all of them had been fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on code in PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#discussion_r913532513


##########
docs/interpreter/jdbc.md:
##########
@@ -827,6 +827,38 @@ Dependencies
   </tr>
 </table>
 
+### Apache Kyuubi
+
+Properties
+
+<table class="table-configuration">
+  <tr>
+    <th>Name</th>
+    <th>Value</th>
+  </tr>
+  <tr>
+    <td>default.driver</td>
+    <td>org.apache.hive.jdbc.HiveDriver</td>
+  </tr>
+  <tr>
+    <td>default.url</td>
+    <td>jdbc:hive2://kyuubi-server:2181/default;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=kyuubi</td>
+  </tr>
+</table>
+
+Dependencies
+
+<table class="table-configuration">
+  <tr>
+    <th>Artifact</th>
+    <th>Excludes</th>
+  </tr>
+  <tr>
+    <td>org.apache.hive:hive-jdbc:2.3.4</td>

Review Comment:
   Thanks @yaooqinn @pan3793 a lot! I would test it with `org.apache.kyuubi:kyuubi-hive-jdbc-shaded:1.5.2-incubating`  and update the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#discussion_r913430788


##########
docs/interpreter/jdbc.md:
##########
@@ -827,6 +827,38 @@ Dependencies
   </tr>
 </table>
 
+### Apache Kyuubi
+
+Properties
+
+<table class="table-configuration">
+  <tr>
+    <th>Name</th>
+    <th>Value</th>
+  </tr>
+  <tr>
+    <td>default.driver</td>
+    <td>org.apache.hive.jdbc.HiveDriver</td>

Review Comment:
    `org.apache.kyuubi.jdbc.KyuubiHiveDriver`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-5694] Support apache kyuubi [zeppelin]

Posted by "Ganlz (via GitHub)" <gi...@apache.org>.
Ganlz commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1840151668

   Logs and result data are mixed in the query result. How to solve this problem?
   
   
   ![20231205-152852(WeLinkPC)](https://github.com/apache/zeppelin/assets/13548413/cd1566c3-8afa-4b96-95a0-35d2fa60d780)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#discussion_r913431041


##########
docs/interpreter/jdbc.md:
##########
@@ -827,6 +827,38 @@ Dependencies
   </tr>
 </table>
 
+### Apache Kyuubi

Review Comment:
   Apache Kyuubi (Incubating)



##########
docs/interpreter/jdbc.md:
##########
@@ -162,7 +162,7 @@ The last step is **Dependency Setting**. Since Zeppelin only includes `PostgreSQ
 
 <img src="{{BASE_PATH}}/assets/themes/zeppelin/img/docs-img/edit_dependencies.png" width="600px" />
 
-That's it. You can find more JDBC connection setting examples([Mysql](#mysql), [MariaDB](#mariadb), [Redshift](#redshift), [Apache Hive](#apache-hive), [Presto/Trino](#prestotrino), [Impala](#impala), [Apache Phoenix](#apache-phoenix), and [Apache Tajo](#apache-tajo)) in [this section](#examples).
+That's it. You can find more JDBC connection setting examples([Mysql](#mysql), [MariaDB](#mariadb), [Redshift](#redshift), [Apache Hive](#apache-hive), [Presto/Trino](#prestotrino), [Impala](#impala), [Apache Kyuubi](#apache-kyuubi), [Apache Phoenix](#apache-phoenix), and [Apache Tajo](#apache-tajo)) in [this section](#examples).

Review Comment:
   Apache Kyuubi (Incubating)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1179534988

   Hi all!  
   I have updated the doc for the review of @pan3793 .
   
   And  though we now use `KyuubiHiveDriver`,  I found the following code still relies on `HiveDriver`.
   ```
             if (jdbcURL != null && jdbcURL.startsWith("jdbc:hive2://")) {
               HiveUtils.startHiveMonitorThread(statement, context,
                       Boolean.parseBoolean(getProperty("hive.log.display", "true")), this);
             }
   ```
   
   I would fix this problem.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1172876590

   > And it is better to give example how to enable kyuubi features via jdbc interpreter
   
   Thanks @zjffdu  a lot for suggestion !  I would improve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org