You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 08:09:37 UTC
[GitHub] [shardingsphere] FlyingZC opened a new issue, #27099: Support parsing Oracle CREATE TABLE sql
FlyingZC opened a new issue, #27099:
URL: https://github.com/apache/shardingsphere/issues/27099
# Background
Hi community,
This issue is for #26878.
ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
# Task
This issue is to support more oracle sql parse, as follows:
```sql
CREATE TABLE employees_obj
( e_name VARCHAR2(100),
e_number NUMBER,
e_dept REF department_typ SCOPE IS departments_obj_t );
```
```sql
CREATE TABLE foo (a NUMBER, b VARCHAR2(20)) RESULT_CACHE (MODE FORCE);
```
```sql
CREATE TABLE employees_obj
( e_name VARCHAR2(100),
e_number NUMBER,
e_dept REF department_typ REFERENCES departments_obj_t);
```
```sql
CREATE TABLE employees_temp AS SELECT * FROM EMPLOYEES;
DECLARE
a_null CHAR(1); -- Set to NULL automatically at run time
BEGIN
EXECUTE IMMEDIATE 'UPDATE employees_temp SET commission_pct = :x'
USING a_null;
END;
```
```sql
CREATE TABLE hr.admin_emp_dept
PARALLEL COMPRESS
AS SELECT * FROM hr.employees
WHERE department_id = 10;
```
# Process
1. First confirm that this is a correct oracle sql syntax, if not please ignore;
2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
4. Run mvn install the current_file_module;
5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
7. Run SQLParserParameterizedTest to make sure no exceptions.
# Relevant Skills
1. Master JAVA language
2. Have a basic understanding of Antlr `g4` file
3. Be familiar with Oracle SQLs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #27099: Support parsing Oracle CREATE TABLE sql
URL: https://github.com/apache/shardingsphere/issues/27099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #27099: Support parsing Oracle CREATE TABLE sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1676080713
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1784213051
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1956049699
@TherChenYang Assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SwapnilPatil07 commented on issue #27099: Support parsing Oracle CREATE TABLE sql
Posted by "SwapnilPatil07 (via GitHub)" <gi...@apache.org>.
SwapnilPatil07 commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1685738953
I added test for below query in the task list
`<sql-case id="create_table_with_ref_column" value="CREATE TABLE employees_obj (e_name VARCHAR2(100),e_number NUMBER, e_dept REF department_typ SCOPE IS departments_obj_t)" db-types="Oracle" />`
but it failed with below error. Column definition needs to be updated for it to work.
```
java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.tree.ParseTree.accept(org.antlr.v4.runtime.tree.ParseTreeVisitor)" because "tree" is null
at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitColumnDefinition(OracleDDLStatementVisitor.java:388)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitColumnDefinition(OracleDDLStatementVisitor.java:298)
at org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser$ColumnDefinitionContext.accept(OracleStatementParser.java:31582)
at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitCreateDefinitionClause(OracleDDLStatementVisitor.java:373)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitCreateDefinitionClause(OracleDDLStatementVisitor.java:298)
at org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser$CreateDefinitionClauseContext.accept(OracleStatementParser.java:29905)
at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitCreateTable(OracleDDLStatementVisitor.java:306)
at org.apache.shardingsphere.sql.parser.oracle.visitor.statement.type.OracleDDLStatementVisitor.visitCreateTable(OracleDDLStatementVisitor.java:298)
at org.apache.shardingsphere.sql.parser.autogen.OracleStatementParser$CreateTableContext.accept(OracleStatementParser.java:25446)
at org.apache.shardingsphere.sql.parser.api.SQLStatementVisitorEngine.visit(SQLStatementVisitorEngine.java:54)
at org.apache.shardingsphere.test.it.sql.parser.internal.InternalSQLParserIT.parseSQLStatement(InternalSQLParserIT.java:64)
at org.apache.shardingsphere.test.it.sql.parser.internal.InternalSQLParserIT.assertSupportedSQL(InternalSQLParserIT.java:56)
at jdk.internal.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]
Posted by "TherChenYang (via GitHub)" <gi...@apache.org>.
TherChenYang commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1956048983
Please assign this issue to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #27099: Support parsing Oracle CREATE TABLE sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1728357292
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SwapnilPatil07 commented on issue #27099: Support parsing Oracle CREATE TABLE sql
Posted by "SwapnilPatil07 (via GitHub)" <gi...@apache.org>.
SwapnilPatil07 commented on issue #27099:
URL: https://github.com/apache/shardingsphere/issues/27099#issuecomment-1676649439
I can work on this issue. Please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org