You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:05:10 UTC
[GitHub] [hop] shlxue opened a new pull request, #1487: [HOP-3921] - Support log level of the message in Abort action
shlxue opened a new pull request, #1487:
URL: https://github.com/apache/hop/pull/1487
Only support three level: Error, Minimal and Basic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1487: [HOP-3921] - Support log level of the message in Abort action
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1487:
URL: https://github.com/apache/hop/pull/1487#issuecomment-1132212820
This PR does not work as expected.
I still always gives back an "error" and the UI does not really make it clear what's to be expected.
I would follow the UI a bit of the transform abort
2 options:
- Abort workflow (but do **not** set nr of errors and result false)
- Abort and log as error (abort and set nr of errors and result false)
and when isAlwaysLogRows is true write the logging to logMinimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1487: [HOP-3921] - Support log level of the message in Abort action
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1487:
URL: https://github.com/apache/hop/pull/1487#issuecomment-1187714954
Yes. AlwaysLogRow option should maintain the same behavior as much as possible, like transform abort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1487: [HOP-3921] - Support log level of the message in Abort action
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1487:
URL: https://github.com/apache/hop/pull/1487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org