[GitHub] geode pull request #305: [GEODE-1923] Fix a test race condition.

[galen-pivotal <gi...@git.apache.org>]

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/305#discussion_r94657673
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java ---
    @@ -293,18 +294,23 @@ public void test_FPAmetadataFetch() {
           putIntoPartitionedRegionsThreeQs();
     
           getFromPartitionedRegionsFor3Qs();
    -      Wait.pause(2000);
    +      // Server 1 is actually primary for both Q1 and Q2, since there is no FPA server with
    +      // primary set to true.
    +      Awaitility.await().atMost(15, TimeUnit.SECONDS).until(
    +          () -> (server1.invoke(() -> FixedPRSinglehopDUnitTest.primaryBucketsOnServer()) == 6)
    --- End diff --
    
    I like this style better, but it conflicts with the style of the rest of the test. I'm inclined to favor consistent style over nicer style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---