[GitHub] [lucene] uschindler commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602597775



##########
File path: gradle/ide/eclipse.gradle
##########
@@ -78,6 +78,8 @@ configure(rootProject) {
         from rootProject.file("${resources}/dot.settings")
         into rootProject.file(".settings")
       }
+      def ecjLintConfig = rootProject.file("gradle/validation/ecj-lint/ecj.javadocs.prefs")
+      rootProject.file(".settings/org.eclipse.jdt.core.prefs") << ecjLintConfig.text.replace("=error","=warning")

Review comment:
       The problem is that '.text" uses the default platform encoding.
   
   So replace this by a method that takes charset.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org