You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/02 18:56:50 UTC

[GitHub] [couchdb-erlfdb] davisp opened a new pull request #10: Add support for reporting conflicting keys

davisp opened a new pull request #10:
URL: https://github.com/apache/couchdb-erlfdb/pull/10


   Transactions that fail due to a conflict can be hard to debug. This
   exposes a recent feature that reports keys that were in conflict if a
   transaction has to be retried due to a conflict.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-erlfdb] davisp merged pull request #10: Add support for reporting conflicting keys

Posted by GitBox <gi...@apache.org>.
davisp merged pull request #10:
URL: https://github.com/apache/couchdb-erlfdb/pull/10


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-erlfdb] davisp commented on pull request #10: Add support for reporting conflicting keys

Posted by GitBox <gi...@apache.org>.
davisp commented on pull request #10:
URL: https://github.com/apache/couchdb-erlfdb/pull/10#issuecomment-685984639


   Forgot to note, this is an option that's new in the unreleased 6.3/master branch of foundationdb. To use these a dev has to set the API verson in `c_src/fdb.h` to `630` to enable them (and that assume's they've built a compatible version locally). These will blow up as unsupported if they're used on anything and won't cause problems if they're not used.
   
   This is just a super useful debugging tool so there shouldn't be a risk of adding a dependency on it before 630 is officially released.
   
   I've not bumped the CouchDB dependency version yet as there are a few more new options that we might want to add first but weren't immediately as useful as being able to report conflict keys.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-erlfdb] nickva commented on pull request #10: Add support for reporting conflicting keys

Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #10:
URL: https://github.com/apache/couchdb-erlfdb/pull/10#issuecomment-685987842


   Also don't forget to set `-define(DEFAULT_API_VERSION, 630).` in `erlfdb_nif.erl` otherwise the C API would accept the Tx option but at runtime the version would still be set to 620 and the get_conflicting_keys/0 function would throw a `2004` error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org