You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/21 06:23:46 UTC
[GitHub] [apisix-dashboard] oil-oil opened a new pull request #2334: chore: Extract paging related functions into standalone hook
oil-oil opened a new pull request #2334:
URL: https://github.com/apache/apisix-dashboard/pull/2334
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Extract paging related functions into standalone hook
**Related issues**
resolve #1621
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2334: chore: Extract paging related functions into standalone hook
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2334:
URL: https://github.com/apache/apisix-dashboard/pull/2334#discussion_r811515149
##########
File path: web/src/hooks/usePagination.ts
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { useEffect, useState } from 'react';
+import { useLocation } from 'umi';
+import { history } from 'umi';
Review comment:
should be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2334: chore: Extract paging related functions into standalone hook
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2334:
URL: https://github.com/apache/apisix-dashboard/pull/2334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] oil-oil commented on pull request #2334: chore: Extract paging related functions into standalone hook
Posted by GitBox <gi...@apache.org>.
oil-oil commented on pull request #2334:
URL: https://github.com/apache/apisix-dashboard/pull/2334#issuecomment-1054881082
@guoqqqi @Baoyuantop Please help me review.😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] oil-oil commented on pull request #2334: chore: Extract paging related functions into standalone hook
Posted by GitBox <gi...@apache.org>.
oil-oil commented on pull request #2334:
URL: https://github.com/apache/apisix-dashboard/pull/2334#issuecomment-1058910969
@LiteSun PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org