[hudi] branch master updated: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics (#1732)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vinoth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new be85a6c  [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics (#1732)
be85a6c is described below

commit be85a6c32bd9ef1931f2af7d268a7e0cb8631002
Author: Shen Hong <sh...@126.com>
AuthorDate: Tue Jul 7 00:44:02 2020 +0800

    [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics (#1732)
---
 .../java/org/apache/hudi/metrics/HoodieGauge.java  | 52 ++++++++++++++++++++++
 .../main/java/org/apache/hudi/metrics/Metrics.java |  4 +-
 2 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/hudi-client/src/main/java/org/apache/hudi/metrics/HoodieGauge.java b/hudi-client/src/main/java/org/apache/hudi/metrics/HoodieGauge.java
new file mode 100644
index 0000000..d69ab4d
--- /dev/null
+++ b/hudi-client/src/main/java/org/apache/hudi/metrics/HoodieGauge.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.metrics;
+
+import com.codahale.metrics.Gauge;
+
+/**
+ * Similar to {@link Gauge}, but metric value can be updated by {@link #setValue(T)}.
+ */
+public class HoodieGauge<T> implements Gauge<T> {
+  private volatile T value;
+
+  /**
+   * Create an instance with a default value.
+   */
+  public HoodieGauge(T value) {
+    this.value = value;
+  }
+
+  /**
+   * Set the metric to a new value.
+   */
+  public void setValue(T value) {
+    this.value = value;
+  }
+
+  /**
+   * Returns the metric's current value.
+   *
+   * @return the metric's current value
+   */
+  @Override
+  public T getValue() {
+    return value;
+  }
+}
diff --git a/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java b/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
index 88e4fce..a68ac26 100644
--- a/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
+++ b/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
@@ -21,7 +21,6 @@ package org.apache.hudi.metrics;
 import org.apache.hudi.config.HoodieWriteConfig;
 import org.apache.hudi.exception.HoodieException;
 
-import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;
 import org.apache.log4j.LogManager;
 import org.apache.log4j.Logger;
@@ -81,7 +80,8 @@ public class Metrics {
   public static void registerGauge(String metricName, final long value) {
     try {
       MetricRegistry registry = Metrics.getInstance().getRegistry();
-      registry.<Gauge<Long>>register(metricName, () -> value);
+      HoodieGauge guage = (HoodieGauge) registry.gauge(metricName, () -> new HoodieGauge<>(value));
+      guage.setValue(value);
     } catch (Exception e) {
       // Here we catch all exception, so the major upsert pipeline will not be affected if the
       // metrics system