You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by pa...@apache.org on 2019/07/23 14:17:49 UTC
svn commit: r1863643 -
/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
Author: painter
Date: Tue Jul 23 14:17:49 2019
New Revision: 1863643
URL: http://svn.apache.org/viewvc?rev=1863643&view=rev
Log:
Clear last PMD issue reported for fulcrum-parser
Modified:
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
Modified: turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java?rev=1863643&r1=1863642&r2=1863643&view=diff
==============================================================================
--- turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java (original)
+++ turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java Tue Jul 23 14:17:49 2019
@@ -534,8 +534,15 @@ public class BaseValueParser
result = new boolean[value.length];
for (int i = 0; i < value.length; i++)
{
- Boolean bool = parseBoolean(value[i]);
- result[i] = (bool == null ? false : bool.booleanValue());
+ // default to false
+ result[i] = false;
+
+ // update with parsed value if exists
+ Boolean bool = parseBoolean(value[i]);
+ if ( bool != null )
+ {
+ result[i] = bool.booleanValue();
+ }
}
}
return result;